From: "Michał Górny" <mgorny@gentoo.org>
To: gentoo-portage-dev@lists.gentoo.org
Subject: Re: [gentoo-portage-dev] [PATCH 0/4] Output rewrite for better clarify and greppability
Date: Tue, 28 Sep 2021 17:37:23 +0200 [thread overview]
Message-ID: <ff0094f2b975afd7b8756dc835a7d9e223f17d7f.camel@gentoo.org> (raw)
In-Reply-To: <CAJ0EP40zk-kyfvyTBKE2VHLJkcpbfG3PMV5DOVQOcSSksNVBUQ@mail.gmail.com>
On Tue, 2021-09-28 at 11:28 -0400, Mike Gilbert wrote:
> On Tue, Sep 28, 2021 at 10:20 AM Michał Górny <mgorny@gentoo.org> wrote:
> >
> > Hi,
> >
> > Ok, so it's more major than I originally intended but I think it's
> > a good direction (once you get used to it). Roughly:
> >
> > 1. All bash color vars are now prefixed with `PORTAGE_COLOR_` to avoid
> > accidental collisions with ebuild vars (e.g. ebuild setting
> > `GOOD=foo` broke `elog` before).
> > 2. There are specific color vars for all kinds of output functions,
> > and now `einfo` messages use distinct color (dark green) from `elog`,
> > and `eqawarn` (brown) from `ewarn`.
> > 3. Messages are now prefixed by their kind, making it possible to
> > distinguish them without colors and grep for specific kind of logs:
> > - `[--]` for einfo & ebegin
> > - `[II]` for elog
> > - `[WW]` for ewarn
> > - `[QA]` for eqawarn
> > - `[EE]` for eerror
> > 4. Finally, I've replaced most of `>>>` and `!!!` in Portage output with
> > four `>>>>` and `!!!!` to align the output again.
>
> I like it.
>
> Maybe add a reference to this bug? https://bugs.gentoo.org/728046
>
Oh right, I also need to work on removing redundant 'QA Notice:'
thingies.
--
Best regards,
Michał Górny
next prev parent reply other threads:[~2021-09-28 15:37 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-28 14:20 [gentoo-portage-dev] [PATCH 0/4] Output rewrite for better clarify and greppability Michał Górny
2021-09-28 14:20 ` [gentoo-portage-dev] [PATCH 1/4] Prefix color vars with "PORTAGE_COLOR_" Michał Górny
2021-09-28 14:20 ` [gentoo-portage-dev] [PATCH 2/4] Use distinct colors for output msg types Michał Górny
2021-09-28 14:20 ` [gentoo-portage-dev] [PATCH 3/4] Use verbose prefixes for output messages Michał Górny
2021-09-28 14:20 ` [gentoo-portage-dev] [PATCH 4/4] Use ">>>>" and "!!!!" for output prefixes Michał Górny
2021-09-28 15:28 ` [gentoo-portage-dev] [PATCH 0/4] Output rewrite for better clarify and greppability Mike Gilbert
2021-09-28 15:37 ` Michał Górny [this message]
2021-10-04 6:49 ` Michał Górny
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ff0094f2b975afd7b8756dc835a7d9e223f17d7f.camel@gentoo.org \
--to=mgorny@gentoo.org \
--cc=gentoo-portage-dev@lists.gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox