From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pigeon.gentoo.org ([69.77.167.62] helo=lists.gentoo.org) by finch.gentoo.org with esmtp (Exim 4.60) (envelope-from ) id 1LW3jt-0003oM-6d for garchives@archives.gentoo.org; Sun, 08 Feb 2009 07:06:02 +0000 Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 8593DE04A1; Sun, 8 Feb 2009 07:05:59 +0000 (UTC) Received: from wf-out-1314.google.com (wf-out-1314.google.com [209.85.200.169]) by pigeon.gentoo.org (Postfix) with ESMTP id 55FEDE04A1 for ; Sun, 8 Feb 2009 07:05:59 +0000 (UTC) Received: by wf-out-1314.google.com with SMTP id 29so1500529wff.10 for ; Sat, 07 Feb 2009 23:05:58 -0800 (PST) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-portage-dev@lists.gentoo.org Reply-to: gentoo-portage-dev@lists.gentoo.org MIME-Version: 1.0 Received: by 10.142.185.21 with SMTP id i21mr2092808wff.220.1234076758898; Sat, 07 Feb 2009 23:05:58 -0800 (PST) In-Reply-To: <20090208063015.GB4076@hrair> References: <20090208063015.GB4076@hrair> Date: Sun, 8 Feb 2009 16:05:58 +0900 Message-ID: Subject: Re: [gentoo-portage-dev] equery: deprecate --category filtering in belongs From: Douglas Anderson To: gentoo-portage-dev@lists.gentoo.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Archives-Salt: 4ed6bfa1-6ca6-4838-8724-c8cb7f0dc5a3 X-Archives-Hash: 25d115d7d1b9a30b6e707a689108c05c On Sun, Feb 8, 2009 at 3:30 PM, Brian Harring wrote: > patch attached against 0.2.4.2-r1; rough stats follow; [snip] > Mind you this isn't multiple runs, so the numbers are rough > approximations- that said they're fairly representative. > > Strongly suggest y'all keep category support (although I'll keep on > using pquery instead ;). > > Cheers, > ~harring > Heh, OK I was looking at my local version of equery where category filtering IS enabled while I was running tests with old equery, which doesn't have it enabled. Thanks for pointing out my stupid mistake, Brian. :) We can in fact even make it go faster by filtering only cat/pkg before it goes through cp_list: - matches = portage.db["/"]["vartree"].dbapi.cpv_all() + matches = gentoolkit.find_all_installed_packages(lambda x: x.startswith(cat)) But still... why? When is it useful? Clearly it has never been used up until now. So I'm still in favor of just dumping it. Seems like complete superfluous fluff to me. If anyone would have any real-world use for this, I'll clean it up and keep it in. Otherwise I really don't think anyone will miss it (especially not Brian :) ) -Doug P.S. I'm strictly talking about belongs here, category filtering in all other modules (where it's actually useful and makes sense) is not only safe but has been upgraded to take multiple categories, so you can now do: $ ./equery.py l --category=app-portage,sys-apps port [ Searching for port in app-portage, sys-apps ... ] * installed packages [I--] [ ] app-portage/portage-utils-0.1.29 (0) [I--] [ ~] sys-apps/portage-2.2_rc23 (0)