Re: [gentoo-portage-dev] [PATCH 0/2] Use consistent list of booleans & validate verify-commit-signature

[Zac Medico <zmedico@gentoo.org>]

[-- Attachment #1.1: Type: text/plain, Size: 1432 bytes --]

On 7/2/20 8:50 AM, Wynn Wolf Arbor wrote:
> Hi,
> 
> Whilst configuring a bunch of overlay repositories via repos.conf, I
> discovered that not all boolean options take the same values. Some only
> take 'true' and 'false', others are documented only as 'yes' or 'no',
> but take 'true', 'false', 'yes', and 'no'. This is inconsistent and can
> lead to very confusing outcomes, so I decided to write a patch.
> 
> I came across https://bugs.gentoo.org/703698 whilst working on this, and
> since my work was tangentially related, decided to fix that as well.
> 
> Wynn Wolf Arbor (2):
>       repos.conf: Use consistent list of values for boolean options
>       git: Verify boolean values passed to sync-git-verify-commit-signature
> 
>  lib/portage/repository/config.py         |  4 +--
>  lib/portage/sync/modules/git/__init__.py | 11 ++++++++
>  lib/portage/sync/modules/git/git.py      |  2 +-
>  lib/portage/sync/modules/rsync/rsync.py  |  2 +-
>  man/portage.5                            | 45 +++++++++++++++-----------------
>  5 files changed, 36 insertions(+), 28 deletions(-)


Thanks! I've merged both patches, with a couple of additional lower()
calls for case insensitivity:

https://gitweb.gentoo.org/proj/portage.git/commit/?id=141ef203661248a2c29945f8c6770ce0c242eaf0
https://gitweb.gentoo.org/proj/portage.git/commit/?id=33b08baff4825bf84f639cf213de92ed36f76771
-- 
Thanks,
Zac




[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 981 bytes --]