From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lists.gentoo.org ([140.105.134.102] helo=robin.gentoo.org) by nuthatch.gentoo.org with esmtp (Exim 4.60) (envelope-from <gentoo-portage-dev+bounces-1479-garchives=archives.gentoo.org@gentoo.org>) id 1Fts2H-0007zi-GD for garchives@archives.gentoo.org; Fri, 23 Jun 2006 20:13:49 +0000 Received: from robin.gentoo.org (localhost [127.0.0.1]) by robin.gentoo.org (8.13.7/8.13.6) with SMTP id k5NKBtgC026646; Fri, 23 Jun 2006 20:11:55 GMT Received: from wr-out-0506.google.com (wr-out-0506.google.com [64.233.184.225]) by robin.gentoo.org (8.13.7/8.13.6) with ESMTP id k5NKBrvB024128 for <gentoo-portage-dev@lists.gentoo.org>; Fri, 23 Jun 2006 20:11:54 GMT Received: by wr-out-0506.google.com with SMTP id i7so749200wra for <gentoo-portage-dev@lists.gentoo.org>; Fri, 23 Jun 2006 13:11:53 -0700 (PDT) DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:to:subject:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=JlwnWOYv9n6D3rZciRIOu5FtHKG9ITtnXDaw1b1LNktz1lDmLv9s1gJFC/oTQwMoziGPAMksZZc4a0z0UvOzU50svY+hBVX62ngVzdFN8/IeTzGHxLsoCu+ztKtDJyHoDsoIyf3suLlZEJHQmLHov0789p/CIAmSwTx9n/NdXE8= Received: by 10.64.156.4 with SMTP id d4mr1626009qbe; Fri, 23 Jun 2006 13:11:52 -0700 (PDT) Received: by 10.65.194.10 with HTTP; Fri, 23 Jun 2006 13:11:52 -0700 (PDT) Message-ID: <e36b84ee0606231311h6ce1108bma8b849482bcb341e@mail.gmail.com> Date: Fri, 23 Jun 2006 14:11:52 -0600 From: "m h" <sesquile@gmail.com> To: gentoo-portage-dev@lists.gentoo.org Subject: Re: [gentoo-portage-dev] Re: Refactoring of emerge code In-Reply-To: <449C48A5.3080900@gentoo.org> Precedence: bulk List-Post: <mailto:gentoo-portage-dev@lists.gentoo.org> List-Help: <mailto:gentoo-portage-dev+help@gentoo.org> List-Unsubscribe: <mailto:gentoo-portage-dev+unsubscribe@gentoo.org> List-Subscribe: <mailto:gentoo-portage-dev+subscribe@gentoo.org> List-Id: Gentoo Linux mail <gentoo-portage-dev.gentoo.org> X-BeenThere: gentoo-portage-dev@gentoo.org Reply-to: gentoo-portage-dev@lists.gentoo.org MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <e36b84ee0604282356v778003ban28734c23216dbfc5@mail.gmail.com> <e36b84ee0604291715o2b3998cdv6abb6c586765fac6@mail.gmail.com> <44544343.5030606@gentoo.org> <e36b84ee0604292258r5e5ad987m19ce75e622756c75@mail.gmail.com> <4455132E.2090709@gentoo.org> <e36b84ee0604301349we5dc6e9k7d331c0d789ed849@mail.gmail.com> <44552EE6.70703@gentoo.org> <e36b84ee0605011354k7e925449la6eceab0d3fc75c5@mail.gmail.com> <e36b84ee0605020035o601083f8nd39ce0d29fec139f@mail.gmail.com> <449C48A5.3080900@gentoo.org> X-Archives-Salt: f2919dd9-ee6c-40aa-bc87-f1a5364c6330 X-Archives-Hash: f1cb34958eee36bc75babeef51d70cf9 Wow, didn't think anyone cared about working with that code these days ;) Cool, I'll check out what you've done. Perhaps I'll do some more refactoring as well. Thanks for the update, I appreciate it. -matt On 6/23/06, Zac Medico <zmedico@gentoo.org> wrote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 > > m h wrote: > > Here's a stab at pre10... > > The order of application is the order of explanation: > > > > globals.diff - remove most globals > > main_emerge.diff - add __main__ section > > emergelint.diff - remove some obvious lint issues (unused/non-existent > > vars) > > emergepychecker.diff - remove unused (and repeated) imports > > I've done lots of refactoring over the last couple days. In the course of that, I've done something quite similar to your main_emerge.diff. There is much more work to be done, but at least it's a start. I've just released the latest changes in 2.1.1_pre1-r2. > > Zac > > -----BEGIN PGP SIGNATURE----- > Version: GnuPG v1.4.3 (GNU/Linux) > > iD8DBQFEnEik/ejvha5XGaMRAt1EAJ9LBTBgnO0468Fx1MiYwg0nRrotpwCcCJFI > nJRe7rWIaWqUyDoN25rgFik= > =swWg > -----END PGP SIGNATURE----- > -- > gentoo-portage-dev@gentoo.org mailing list > > -- gentoo-portage-dev@gentoo.org mailing list