public inbox for gentoo-portage-dev@lists.gentoo.org
 help / color / mirror / Atom feed
From: "Sid Spry" <sid@aeam.us>
To: gentoo-portage-dev@lists.gentoo.org
Subject: Re: [gentoo-portage-dev] Speeding up Tree Verification
Date: Wed, 01 Jul 2020 17:05:38 -0500	[thread overview]
Message-ID: <e1cd8450-fb23-4c28-941e-1e045168fd82@www.fastmail.com> (raw)
In-Reply-To: <20200701064052.GS37387@gentoo.org>

On Wed, Jul 1, 2020, at 1:40 AM, Fabian Groffen wrote:
> On 30-06-2020 13:13:29 -0500, Sid Spry wrote:
> > On Tue, Jun 30, 2020, at 1:20 AM, Fabian Groffen wrote:
> > > Hi,
> > > 
> > > On 29-06-2020 21:13:43 -0500, Sid Spry wrote:
> > > > Hello,
> > > > 
> > > > I have some runnable pseudocode outlining a faster tree verification algorithm.
> > > > Before I create patches I'd like to see if there is any guidance on making the
> > > > changes as unobtrusive as possible. If the radical change in algorithm is
> > > > acceptable I can work on adding the changes.
> > > > 
> > > > Instead of composing any kind of structured data out of the portage tree my
> > > > algorithm just lists all files and then optionally batches them out to threads.
> > > > There is a noticeable speedup by eliding the tree traversal operations which
> > > > can be seen when running the algorithm with a single thread and comparing it to
> > > > the current algorithm in gemato (which should still be discussed here?).
> > > 
> > > I remember something that gemato used to use multiple threads, but
> > > because it totally saturated disk-IO, it was brought back to a single
> > > thread.  People were complaining about unusable systems.
> > > 
> > 
> > I think this is an argument for cgroups limits support on the portage process or
> > account as opposed to an argument against picking a better algorithm. That is
> > something I have been working towards, but I am only one man.
> 
> But this requires a) cgroups support, and b) the privileges to use it.
> Shouldn't be a problem in the normal case, but just saying.
> 

cgroups kernel support is a fairly common dependency. It can obviously be optional,
I am thinking related to MAKEOPTS or EMERGE_DEFAULT_OPTS (see: rustc/cargo not
respecting or being passed -j/-l as another use for cgroups) and supported best-effort,
but is there any reason to expect it to not be enabled?

If the user isn't either root or portage I think it reasonable to leave resource management
to the machine's administrator.


  parent reply	other threads:[~2020-07-01 22:06 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-30  2:13 [gentoo-portage-dev] Speeding up Tree Verification Sid Spry
2020-06-30  2:15 ` [gentoo-portage-dev] " Sid Spry
2020-06-30  2:34   ` Zac Medico
2020-06-30 17:29     ` Sid Spry
2020-06-30 18:18       ` Zac Medico
2020-06-30  6:20 ` [gentoo-portage-dev] " Fabian Groffen
2020-06-30  7:30   ` Michał Górny
2020-06-30 14:16   ` Pacho Ramos
2020-06-30 18:13   ` Sid Spry
2020-07-01  6:40     ` Fabian Groffen
2020-07-01 20:25       ` Sid Spry
2020-07-01 22:05       ` Sid Spry [this message]
2020-06-30  7:28 ` Michał Górny
2020-06-30 17:50   ` Sid Spry
2020-06-30 19:29     ` Michał Górny
2020-06-30 21:51       ` Sid Spry
2020-07-01 12:38         ` Michał Górny

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e1cd8450-fb23-4c28-941e-1e045168fd82@www.fastmail.com \
    --to=sid@aeam.us \
    --cc=gentoo-portage-dev@lists.gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox