public inbox for gentoo-portage-dev@lists.gentoo.org
 help / color / mirror / Atom feed
From: Zac Medico <zmedico@gentoo.org>
To: gentoo-portage-dev@lists.gentoo.org, "Ulrich Müller" <ulm@gentoo.org>
Subject: Re: [gentoo-portage-dev] [PATCH] repoman: Remove http compatibility code for metadata DTD
Date: Sat, 29 Jan 2022 09:25:49 -0800	[thread overview]
Message-ID: <d6d01a68-5490-83a6-bef6-5a1c04cb5b6d@gentoo.org> (raw)
In-Reply-To: <20220125164427.12678-1-ulm@gentoo.org>


[-- Attachment #1.1: Type: text/plain, Size: 1197 bytes --]

On 1/25/22 08:44, Ulrich Müller wrote:
> Commit 3950d76df says: "The http:// compat can be removed once the
> Gentoo repository is updated to use https:// everywhere."
> 
> Bug: https://bugs.gentoo.org/552720
> Signed-off-by: Ulrich Müller <ulm@gentoo.org>
> ---
>   repoman/lib/repoman/modules/scan/metadata/pkgmetadata.py | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/repoman/lib/repoman/modules/scan/metadata/pkgmetadata.py b/repoman/lib/repoman/modules/scan/metadata/pkgmetadata.py
> index b4e0ee933..0fb97a0df 100644
> --- a/repoman/lib/repoman/modules/scan/metadata/pkgmetadata.py
> +++ b/repoman/lib/repoman/modules/scan/metadata/pkgmetadata.py
> @@ -127,7 +127,7 @@ class PkgMetadata(ScanBase, USEFlagChecks):
>               )
>           else:
>               doctype_system = _metadata_xml.docinfo.system_url
> -            if doctype_system.replace("http://", "https://") != metadata_dtd_uri:
> +            if doctype_system != metadata_dtd_uri:
>                   if doctype_system is None:
>                       system_problem = "but it is undefined"
>                   else:

Looks good. Please merge.
-- 
Thanks,
Zac

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 840 bytes --]

      reply	other threads:[~2022-01-29 17:25 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-25 16:44 [gentoo-portage-dev] [PATCH] repoman: Remove http compatibility code for metadata DTD Ulrich Müller
2022-01-29 17:25 ` Zac Medico [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d6d01a68-5490-83a6-bef6-5a1c04cb5b6d@gentoo.org \
    --to=zmedico@gentoo.org \
    --cc=gentoo-portage-dev@lists.gentoo.org \
    --cc=ulm@gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox