From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 6E1221382C5 for ; Sun, 18 Feb 2018 16:35:42 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 4455BE09D8; Sun, 18 Feb 2018 16:35:41 +0000 (UTC) Received: from avasout06.plus.net (avasout06.plus.net [212.159.14.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id E7F1BE09CF for ; Sun, 18 Feb 2018 16:35:40 +0000 (UTC) Received: from [192.168.6.147] ([212.159.46.162]) by smtp with ESMTP id nRwAekMDKVrdRnRwBeB4qs; Sun, 18 Feb 2018 16:35:39 +0000 X-CM-Score: 0.00 X-CNFS-Analysis: v=2.3 cv=XZynMrx5 c=1 sm=1 tr=0 a=RuViaDnnNG9rfPLW4VJocg==:117 a=RuViaDnnNG9rfPLW4VJocg==:17 a=13zjGPudsaEWiJwPRgMA:9 a=xtxXYLxNAAAA:8 a=8OHS__GNRwDJh67ia_EA:9 a=QEXdDO2ut3YA:10 a=6dIM39BlFqE8_B52jqwA:9 a=ONNS8QRKHyMA:10 a=xts0dhWdiJbonKbuqhAr:22 Subject: Re: [gentoo-portage-dev] [PATCH v2 1/3] repoman: Add commit message verification To: gentoo-portage-dev@lists.gentoo.org References: <20180217125648.1697-1-mgorny@gentoo.org> <750976a1-5cfc-4dd8-eed0-5b464240ec59@iee.org> <20180218082813.6057e0c2@professor-x> From: "M. J. Everitt" Openpgp: id=BA266E0525CFAB101523351B4C30334F93C22371 Message-ID: Date: Sun, 18 Feb 2018 16:35:32 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-portage-dev@lists.gentoo.org Reply-to: gentoo-portage-dev@lists.gentoo.org MIME-Version: 1.0 In-Reply-To: <20180218082813.6057e0c2@professor-x> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="clJ9qQAkvfSSldBOuI3X3vZ4Hd3ol1c0P" X-CMAE-Envelope: MS4wfMh1/1j4Dz7cKCJiAda8lXDakCR9Mk6HJema+oyFmh74xHmA1Ppl/d66UMCnBt5UElm37iEXWy/Q4vfAZJADRchNpuCHc+B/Sc1NtA2N7Jt3w8/lucmj pCIagYKixeS/kNHolaK7T63XzdraJQa+GzFH8Lk2ieSdN5EY5Pnq+Z/1+bx+D0Xs7Xs3WKdvrudGn0UQNXcb7D9rnxRL434cz+4= X-Archives-Salt: 782f70e4-e325-48a0-b674-28e2d6ed153c X-Archives-Hash: cb56e5caa49f0adf3818e54cb8113627 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --clJ9qQAkvfSSldBOuI3X3vZ4Hd3ol1c0P Content-Type: multipart/mixed; boundary="B9JmGRuhUB56RuzJpsMefEqdm8hX9Y9Qk"; protected-headers="v1" From: "M. J. Everitt" To: gentoo-portage-dev@lists.gentoo.org Message-ID: Subject: Re: [gentoo-portage-dev] [PATCH v2 1/3] repoman: Add commit message verification References: <20180217125648.1697-1-mgorny@gentoo.org> <750976a1-5cfc-4dd8-eed0-5b464240ec59@iee.org> <20180218082813.6057e0c2@professor-x> In-Reply-To: <20180218082813.6057e0c2@professor-x> --B9JmGRuhUB56RuzJpsMefEqdm8hX9Y9Qk Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Content-Language: en-GB On 18/02/18 16:28, Brian Dolbec wrote: > On Sat, 17 Feb 2018 13:18:03 +0000 > "M. J. Everitt" wrote: > >> Might I suggest breaking out checks into a separate module? I think >> that hard-coding it all is likely to become a pain as time goes on, >> more checks get added, etc=C2=A0 ... >> > So, you would like the commit message checks to be a plug-in system > like the ebuild checks are now. > > Yes that is possible, that would also allow overlays and sub-distros > to customize it to their liking. But you do realize it would be a > module system with only the one plug-in. It would add a slight amount > of overhead and subsequently a tiny bit more time. Although it is not > much as I remember when I first developed the plug-in system for emaint= =2E > > I will consider that for the stage3 work in progress, but for the > master branch of repoman, the hard-coded version above would be fine. > That's probably a better implementation, but for the time being I was thinking more of an 'actions_commit' module to break out the extra code from the generic 'actions' module. Regards, Michael/veremitz. --B9JmGRuhUB56RuzJpsMefEqdm8hX9Y9Qk-- --clJ9qQAkvfSSldBOuI3X3vZ4Hd3ol1c0P Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJaiatZAAoJEGPnxnn01DHdxKwQALs/5yShqpcYUpDVfyu7LzZA O/V08zO90okAcwGKbhEX2EtorH8D+4UHW4IKugHyaCb/5gD9DjiZdSxj/RqlKFe4 +AaYHfulJMo6LjEI0FvCYPf+sR4la0MbsCFLC4oDV+dTGsqtIaWSXWjq/UcsC+6H Zw/TWdFezdRdSVhLpFqYYzj7M0NRPX3wf8SiTNgenzNQrdov0B5EWIez5yLv7Z7U eHkj2CDn3IapAXsF0FAylzI5K5otmCnJxzuqKUdRuZiOV1N44h4ZDTb8CuPFtUi/ hkdBcXxHKbkE57JNdSnxaCjlNRCW7WRcn5PVvBoYCg1h4APThB/SHG0rgE45d2ya eAvgLFE8zkXV9FyLYNHjwf3LbiXUWNdrCaGjlr40adKK9XZNs887nT2f1wr7vsTX PKQSXXgLBITBojvgFTBEWRhEzX3GAEsDoqWTV52pnVvr6P6O6/3XW7ZS7ISfxcgr 96cslz8wJDO/pLLN5REfhHYLVPPMBsGd0hkQ4tMibgAbVjllonpGGPtvv53eW5DP NjSMGMacbaKnEhaIZMi8KR2NsO5LHSgyIlmtSbZcneRBHfa8FjREkuFNGoU2O4eB kD3q09obks+z0pD3gDcbrKvKcjdZdbFGCWabQ6lNW+RFg4jeqoJGSCNVi3puw/fU gPX3npK3wWHUB5ycb8Wu =nsL3 -----END PGP SIGNATURE----- --clJ9qQAkvfSSldBOuI3X3vZ4Hd3ol1c0P--