From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 2C5FA1396D0 for ; Mon, 14 Aug 2017 19:49:52 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 89CA2E090A; Mon, 14 Aug 2017 19:49:51 +0000 (UTC) Received: from avasout05.plus.net (avasout05.plus.net [84.93.230.250]) (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 2FEBEE08C3 for ; Mon, 14 Aug 2017 19:49:50 +0000 (UTC) Received: from [192.168.6.147] ([212.159.46.162]) by avasout05 with smtp id x7po1v0063Vx3VQ017ppFT; Mon, 14 Aug 2017 20:49:49 +0100 X-CM-Score: 0.00 X-CNFS-Analysis: v=2.2 cv=Iav3YSia c=1 sm=1 tr=0 a=RuViaDnnNG9rfPLW4VJocg==:117 a=RuViaDnnNG9rfPLW4VJocg==:17 a=13zjGPudsaEWiJwPRgMA:9 a=cm27Pg_UAAAA:8 a=zalhV6wptMTWv7tW4B4A:9 a=pILNOxqGKmIA:10 a=bqzz-wrigEN209mnuVUA:9 a=ONNS8QRKHyMA:10 a=xmb-EsYY8bH0VWELuYED:22 Subject: Re: [gentoo-portage-dev] [PATCH] Rewrite doins in python (bug 624526) To: gentoo-portage-dev@lists.gentoo.org References: <20170814073921.20837-1-zmedico@gentoo.org> From: "M. J. Everitt" Openpgp: id=BA266E0525CFAB101523351B4C30334F93C22371 Message-ID: Date: Mon, 14 Aug 2017 20:49:43 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-portage-dev@lists.gentoo.org Reply-to: gentoo-portage-dev@lists.gentoo.org MIME-Version: 1.0 In-Reply-To: <20170814073921.20837-1-zmedico@gentoo.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="xqtf1KtOve4JvxP0ohgTGfIindikrgVoP" X-Archives-Salt: 2c0eb3a2-ea12-4800-8c95-7861297033d6 X-Archives-Hash: af4d9f004a58cb2f055d2a9e04ecff68 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --xqtf1KtOve4JvxP0ohgTGfIindikrgVoP Content-Type: multipart/mixed; boundary="Kh1EaEBvJoat1EFOVRw7PIXoqo4DIv7MN"; protected-headers="v1" From: "M. J. Everitt" To: gentoo-portage-dev@lists.gentoo.org Message-ID: Subject: Re: [gentoo-portage-dev] [PATCH] Rewrite doins in python (bug 624526) References: <20170814073921.20837-1-zmedico@gentoo.org> In-Reply-To: <20170814073921.20837-1-zmedico@gentoo.org> --Kh1EaEBvJoat1EFOVRw7PIXoqo4DIv7MN Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable On 14/08/17 08:39, Zac Medico wrote: > From: Hidehiko Abe > > doins is written in bash. However, specifically in case that > too many files are installed, it is very slow. > This CL rewrites the script in python for performance. > > BUG=3Dchromium:712659 > TEST=3Dtime (./setup_board --forace && \ > ./build_package --withdev && \ > ./build_image --noenable_rootfs_verification test) > =3D=3D=3DBefore=3D=3D=3D > real 21m35.445s > user 93m40.588s > sys 21m31.224s > > =3D=3D=3DAfter=3D=3D=3D > real 17m30.106s > user 94m1.812s > sys 20m13.468s > I know I'm gonna get chewed out on this one, but here goes anyway ... Surely for a package like chromium, who's build time is already in the 'hours' range anyway, surely a couple of minutes gain for the install phase is neither here nor there?! If there were some genuine filesystem iop gains/etc for this change, I think I'd likely support it further .. On this basis, what do the performance differences look like on an 'average' package .. and are there any regressions in this regard?! I take issue with the copyright assignment, as I believe the legal .. err .. IANAL devs are campaigning for full rights to be owned and enforced by Gentoo Inc LLC in the US .. even if they have no idea what that means or does .. :] MJE --Kh1EaEBvJoat1EFOVRw7PIXoqo4DIv7MN-- --xqtf1KtOve4JvxP0ohgTGfIindikrgVoP Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJZkf7cAAoJEN7KWvRhIveDsncQALnADZKoBZtC0PXbeCxWr2Jm SFS+bhJkRhubIXDhwz3DnFTMn7VJsWuIQGYpN+SWKEIebJARgUDTauMGjROQ6vy9 NdlrlnSkZtzoJQJOrE40BLE7XKNcYDineoXNcJ+DU0n93zqm0u62B9pAOHC1XqfH hoISM5b6EyJ5qTeuHbWVSeCoebXofbMwL6eCeP9MelO5pZ6Yq4yo577Z44QYACYd ZR7NLGFbmdMCF9TCViGECPCUipa47OmBnsn39UelHsBtnXsTSYKDsVWT9fCesVrC fZxKT/8JKCEtYuq2qcUgiNKyR9Zfjrru7RA1BbquybcFXWGqchkf0wXRlNOnSQrx nTyX28YS1ib5HJtjNasF4Im7myyskOycYBunX0Ty7XTGa0KTpp48VGHvyMJx58aG 39OcQnuXDgndHf8W3QZGQr02J1lL4UIn1IpEf9laOyl3OKtJrM4IIWptjhM7aEm7 b754Qr7QKtmjDkBKN7RDryEOaAnEbmozFUBpKQyccK+U5Bd4GKnJjkAf8oSONe9r CMTBQbyfyXR0vbjHEPHAPMF/5Ad+hu11Tbw+Rdvx7PExMZdbCeqtKuZoHahFmsTw GBw4BeZy70u2jCWISMcybqDy9bo4V5fv538yHqSNWFvDAcjq+XXxTtygYNyFkYog sp6O50AJyNlAY0uHNyGo =gpfs -----END PGP SIGNATURE----- --xqtf1KtOve4JvxP0ohgTGfIindikrgVoP--