Re: [gentoo-portage-dev] [PATCH] Rewrite doins in python (bug 624526)

["M. J. Everitt" <m.j.everitt@iee.org>]

[-- Attachment #1.1: Type: text/plain, Size: 1341 bytes --]

On 14/08/17 08:39, Zac Medico wrote:
> From: Hidehiko Abe <hidehiko@chromium.org>
>
> doins is written in bash. However, specifically in case that
> too many files are installed, it is very slow.
> This CL rewrites the script in python for performance.
>
> BUG=chromium:712659
> TEST=time (./setup_board --forace && \
>      ./build_package --withdev && \
>      ./build_image --noenable_rootfs_verification test)
> ===Before===
> real    21m35.445s
> user    93m40.588s
> sys     21m31.224s
>
> ===After===
> real    17m30.106s
> user    94m1.812s
> sys     20m13.468s
>
I know I'm gonna get chewed out on this one, but here goes anyway ...

Surely for a package like chromium, who's build time is already in the
'hours' range anyway, surely a couple of minutes gain for the install
phase is neither here nor there?! If there were some genuine filesystem
iop gains/etc for this change, I think I'd likely support it further ..

On this basis, what do the performance differences look like on an
'average' package .. and are there any regressions in this regard?!

I take issue with the copyright assignment, as I believe the legal ..
err .. IANAL devs are campaigning for full rights to be owned and
enforced by Gentoo Inc LLC in the US .. even if they have no idea what
that means or does .. :]

MJE


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]