From: Fabian Groffen <grobian@gentoo.org>
To: gentoo-portage-dev@lists.gentoo.org
Subject: Re: [gentoo-portage-dev] [PATCH] multilib-strict: fix for Prefix
Date: Tue, 26 Jul 2022 20:47:41 +0200 [thread overview]
Message-ID: <YuA2zR7cPR2hhA39@gentoo.org> (raw)
In-Reply-To: <CAJ0EP428J_mU0U=nHGVqedG4nv4sHrbkii07erO0E_KgQLTF8Q@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1037 bytes --]
On 25-07-2022 19:38:57 -0400, Mike Gilbert wrote:
> On Mon, Jul 25, 2022 at 12:26 PM Fabian Groffen <grobian@gentoo.org> wrote:
> >
> > bin/install-qa-check.d/80multilib-strict: use file/find from Prefix
> >
> > diff --git a/bin/install-qa-check.d/80multilib-strict b/bin/install-qa-check.d/80multilib-strict
> > index afd223250..3db4ecce3 100644
> > --- a/bin/install-qa-check.d/80multilib-strict
> > +++ b/bin/install-qa-check.d/80multilib-strict
> > @@ -1,7 +1,7 @@
> > # Strict multilib directory checks
> > multilib_strict_check() {
> > if has multilib-strict ${FEATURES} && \
> > - [[ -x /usr/bin/file && -x /usr/bin/find ]] && \
> > + [[ -x ${EPREFIX}/usr/bin/file && -x ${EPREFIX}/usr/bin/find ]] && \
> > [[ -n ${MULTILIB_STRICT_DIRS} && -n ${MULTILIB_STRICT_DENY} ]]
> > then
> > rm -f "${T}/multilib-strict.log"
>
> Seems good to me.
https://github.com/gentoo/portage/pull/868
Thanks
--
Fabian Groffen
Gentoo on a different level
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2022-07-26 18:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-25 16:26 [gentoo-portage-dev] [PATCH] multilib-strict: fix for Prefix Fabian Groffen
2022-07-25 23:38 ` Mike Gilbert
2022-07-26 18:47 ` Fabian Groffen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YuA2zR7cPR2hhA39@gentoo.org \
--to=grobian@gentoo.org \
--cc=gentoo-portage-dev@lists.gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox