Re: [gentoo-portage-dev] [PATCH] 80libraries: add support for Darwin targets

[Fabian Groffen <grobian@gentoo.org>]

[-- Attachment #1: Type: text/plain, Size: 1239 bytes --]

On 26-07-2022 04:01:37 +0100, Sam James wrote:
> 
> 
> > On 26 Jul 2022, at 00:33, Mike Gilbert <floppym@gentoo.org> wrote:
> > 
> > On Mon, Jul 25, 2022 at 11:38 AM Fabian Groffen <grobian@gentoo.org> wrote:
> >> 
> >> bin/install-qa-check.d/80libraries: support Darwin/Mach-O objects
> >> 
> >> Check for dylib on Darwin, so on everything else.
> >> 
> >> Signed-off-by: Fabian Groffen <grobian@gentoo.org>
> >> 
> >> diff --git a/bin/install-qa-check.d/80libraries b/bin/install-qa-check.d/80libraries
> >> index 8dc35bb87..a477ec9cb 100644
> >> --- a/bin/install-qa-check.d/80libraries
> >> +++ b/bin/install-qa-check.d/80libraries
> >> @@ -140,7 +140,9 @@ lib_check() {
> >>        local abort="no"
> >>        local a s
> >>        for a in "${ED%/}"/usr/lib*/*.a ; do
> >> -               s=${a%.a}.so
> >> +               [[ ${CHOST} == *-darwin* ]] \
> >> +                       && s=${a%.a}.dylib \
> >> +                       || s=${a%.a}.so
> > 
> > I would find this much easier to read if you converted it to an
> > if/else statement instead of chaining && and ||.
> 
> Yes, please.

https://github.com/gentoo/portage/pull/867

Thanks


-- 
Fabian Groffen
Gentoo on a different level

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]