public inbox for gentoo-portage-dev@lists.gentoo.org
 help / color / mirror / Atom feed
From: Arfrever Frehtes Taifersar Arahesis <arfrever.fta@gmail.com>
To: gentoo-portage-dev@lists.gentoo.org
Subject: Re: [gentoo-portage-dev] [PATCH] emake: explicitly set SHELL
Date: Thu, 28 Jul 2022 19:36:09 +0200	[thread overview]
Message-ID: <CALaCa4zbRYOJm00bGnZ3CqeA1A12K3RTiNQoJMO9j-G-T3eaOg@mail.gmail.com> (raw)
In-Reply-To: <558a19e9-9dc2-24c3-c25b-5b6f23003a00@gentoo.org>

2022-07-26 07:03 UTCに、Florian Schmaus <flow@gentoo.org>は書いた:
> But then I wondered if "make SHELL=$BROOT/bin/sh" wouldn't override
> explicitly set SHELL values in Makefiles. Assume a package has
>
> SHELL = /bin/zsh
>
> in one of its Makefiles. Then emake would reset this to 'sh'. Which
> appears like it could cause build issues.
>
> If this is the case, then I am not sure what we can do about it. It
> appears fragile, if not impossible, to ask 'make' which value for SHELL
> it would assume, so that emake could adjust the path. Another option
> could be that affected packages define a variable in their ebuild, e.g.
> EMAKE_SHELL="zsh", which emake could extend with BROOT before passing
> the resulting value as SHELL to make.

If there was such package, it could just override SHELL on emake invocation:

src_compile() {
    emake SHELL="${BROOT}/bin/zsh"
    # Or:
    emake SHELL="$(type -P zsh)"
}


      parent reply	other threads:[~2022-07-28 17:36 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-25 15:28 [gentoo-portage-dev] [PATCH] emake: explicitly set SHELL Fabian Groffen
2022-07-25 23:38 ` Mike Gilbert
2022-07-26  3:00 ` Sam James
2022-07-26  3:02   ` Sam James
2022-07-26  7:03   ` Florian Schmaus
2022-07-26  7:20     ` Fabian Groffen
2022-07-28 17:12       ` Fabian Groffen
2022-07-28 17:36     ` Arfrever Frehtes Taifersar Arahesis [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CALaCa4zbRYOJm00bGnZ3CqeA1A12K3RTiNQoJMO9j-G-T3eaOg@mail.gmail.com \
    --to=arfrever.fta@gmail.com \
    --cc=gentoo-portage-dev@lists.gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox