From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id 2A449138CD0 for ; Sat, 30 May 2015 18:42:29 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 604FAE08CE; Sat, 30 May 2015 18:42:27 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id D2BF2E08CD for ; Sat, 30 May 2015 18:42:26 +0000 (UTC) Received: from mail-ig0-f171.google.com (mail-ig0-f171.google.com [209.85.213.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: floppym) by smtp.gentoo.org (Postfix) with ESMTPSA id 98360340D1A for ; Sat, 30 May 2015 18:42:25 +0000 (UTC) Received: by igbsb11 with SMTP id sb11so36363836igb.0 for ; Sat, 30 May 2015 11:42:23 -0700 (PDT) X-Received: by 10.50.64.244 with SMTP id r20mr4052532igs.33.1433011343231; Sat, 30 May 2015 11:42:23 -0700 (PDT) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-portage-dev@lists.gentoo.org Reply-to: gentoo-portage-dev@lists.gentoo.org MIME-Version: 1.0 Received: by 10.107.144.4 with HTTP; Sat, 30 May 2015 11:42:02 -0700 (PDT) In-Reply-To: <20150530101852.7b180cdf.dolsen@gentoo.org> References: <1433003354-18413-1-git-send-email-vapier@gentoo.org> <20150530101852.7b180cdf.dolsen@gentoo.org> From: Mike Gilbert Date: Sat, 30 May 2015 14:42:02 -0400 Message-ID: Subject: Re: [gentoo-portage-dev] [PATCH] runtests: rewrite in python To: gentoo-portage-dev@lists.gentoo.org Content-Type: text/plain; charset=UTF-8 X-Archives-Salt: 2b59f7bd-c956-43c0-af76-60127e0f1d56 X-Archives-Hash: 0f7a0a3d407d4f484d9bb570db831fd4 On Sat, May 30, 2015 at 1:18 PM, Brian Dolbec wrote: > On Sat, 30 May 2015 12:29:14 -0400 > Mike Frysinger wrote: > >> The bash was getting ugly, and this allows us to add more smarts >> sanely to the main script. >> --- >> DEVELOPING | 2 +- >> runtests | 156 >> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ >> runtests.sh | 109 ------------------------------------------ 3 files >> changed, 157 insertions(+), 110 deletions(-) create mode 100755 >> runtests delete mode 100755 runtests.sh >> >> diff --git a/DEVELOPING b/DEVELOPING >> index 0b0bb60..31b5594 100644 >> --- a/DEVELOPING >> +++ b/DEVELOPING >> @@ -225,7 +225,7 @@ Second create a git tag for this release: >> Then create the tarball and run the tests: >> ./mkrelease.sh --changelog-rev v2.2.7 --tag --runtests 2.2.8 >> Make sure you have all supported python versions installed first >> -(see PYTHON_SUPPORTED_VERSIONS in runtests.sh). >> +(see PYTHON_SUPPORTED_VERSIONS in runtests). >> >> Version bump the ebuild and verify it can re-install itself: >> emerge portage >> diff --git a/runtests b/runtests >> new file mode 100755 >> index 0000000..d1f7b6f >> --- /dev/null >> +++ b/runtests >> + > > >> +from __future__ import print_function >> > > If I'm not mistaken, this is not needed for 2.7+ anymore. It is > still for 2.6 though. You are mistaken. Without this, print is still treated as a statement and anything in parens is treated as a tuple. % python2.7 --version Python 2.7.10 % python2.7 -c "print(1, 2, 3)" (1, 2, 3) % python2.7 -c "from __future__ import print_function; print(1, 2, 3)" 1 2 3