From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id 62D8C13800E for ; Thu, 2 Aug 2012 21:09:22 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 05CB6E0586 for ; Thu, 2 Aug 2012 21:09:21 +0000 (UTC) Received: from mail-lpp01m010-f53.google.com (mail-lpp01m010-f53.google.com [209.85.215.53]) by pigeon.gentoo.org (Postfix) with ESMTP id 3EE1CE07B2 for ; Thu, 2 Aug 2012 19:57:44 +0000 (UTC) Received: by lagu2 with SMTP id u2so5506925lag.40 for ; Thu, 02 Aug 2012 12:57:44 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :content-type:content-transfer-encoding:x-gm-message-state; bh=m/8X+G1HbhK5xrSycgvpMa/gkm8ikKgD40HTFssh6CE=; b=cFAEDsai/aAcQm+TCYeuRVpNEaiZqvaMZmXI9Bi0+BtTp2312r0VighYjPdtF1OMaL Uup8ClL2GexH2EIQBRfiTaKk0PrAR9GdBeH8BYFZWhFqNJ+j2siTwZWe++kD73FJPOKg xScRx+FtsD0zV0fWsrHzDnnkUQNTcqcZ/L/xi7zFdmh7DmKkmHiEsnZFyLu0kWGUFvMy +KUBOpefpXfuPQqnVKCESmA1RwyrUFT8jj2swCVbvA/CoTVshQayEtPdgh834iIRX+IW EsiwXlVqWnD1FMvzou5r1XWk3KMTRr2PEhhI6OsvtrRgaJvaehANa0K5pPi/5yYNHJx0 OU6A== Received: by 10.112.40.231 with SMTP id a7mr758774lbl.67.1343937463994; Thu, 02 Aug 2012 12:57:43 -0700 (PDT) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-portage-dev@lists.gentoo.org Reply-to: gentoo-portage-dev@lists.gentoo.org MIME-Version: 1.0 Received: by 10.112.21.103 with HTTP; Thu, 2 Aug 2012 12:57:23 -0700 (PDT) In-Reply-To: <5019E686.5030407@gentoo.org> References: <5019D1B7.5050807@gentoo.org> <5019E686.5030407@gentoo.org> From: Mark Kubacki Date: Thu, 2 Aug 2012 21:57:23 +0200 Message-ID: Subject: Re: [gentoo-portage-dev] [PATCH] portage: HTTP if-modified-since and compression To: gentoo-portage-dev@lists.gentoo.org Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Gm-Message-State: ALoCoQmoZwZiFDQxMFqQocPBiJDgOEptwQhdztPcN5QkYT1/h6LLLQYBtGhkAE8p8V38G5fpTqgw X-Archives-Salt: 19481fea-44f0-4323-9223-95cc5343be5f X-Archives-Hash: 67e909e2a85539885c56e3b8e6e6caa6 2012/8/2 Zac Medico : > On 08/01/2012 06:02 PM, Zac Medico wrote: >> >> Thanks, I've applied your patches: >> >> http://git.overlays.gentoo.org/gitweb/?p=3Dproj/portage.git;a=3Dcommit;h= =3De06cb6d66db37ac7ab77acf65038b1f770c13c96 >> http://git.overlays.gentoo.org/gitweb/?p=3Dproj/portage.git;a=3Dcommit;h= =3Dcbebf76d8e5666aad4984f87c2be83d474fe5a7e >> http://git.overlays.gentoo.org/gitweb/?p=3Dproj/portage.git;a=3Dcommit;h= =3D13abe0398fbe724218c8c9ac2597ebe15d7db7e1 >> >> I made a few trivial change in order to make them compatible with >> python3. Also, I made it use the old behavior for protocols other than >> http and https, in order to avoid issues with ftp like this one: >> >> https://bugs.gentoo.org/show_bug.cgi?id=3D415579 >> > > Fix python2 http password breakage: > > http://git.overlays.gentoo.org/gitweb/?p=3Dproj/portage.git;a=3Dcommit;h= =3Dfbeb8101b20e232b2e8c55c9554b5fc9c5c72089 > > BUG: The if_modified_since parameter appears to be ignored when using > http password authentication. Hi Zac, In one word: Great! I love your modifications. Thank you! Regarding functionality =E2=80=93 there is still some room for more optimizations and more features. For example, if the local copy is no older than x seconds then there's no need to contact any remote server. Expect patches. As for the bug. As long as the "If-Modified-Since" header is sent Portage has done its job. Some servers use the header as "ETag" replacement and don't do the more costly greater-than comparison (see also [1]; TIMESTAMP_TOLERANCE should be a configuration option so users can set it to 0 now that the "mtime"-patch has been accepted). And, BaseHandler are chained automatically by "build_opener". Nevertheless, I will look into the whole issue the next days. --=20 Gr=C3=BC=C3=9Fe, Mark