Re: [gentoo-portage-dev] [PATCH] portage: HTTP if-modified-since and compression

[Mark Kubacki <wmark@hurrikane.de>]

2012/8/2 Zac Medico <zmedico@gentoo.org>:
> On 08/01/2012 06:02 PM, Zac Medico wrote:
>>
>> Thanks, I've applied your patches:
>>
>> http://git.overlays.gentoo.org/gitweb/?p=proj/portage.git;a=commit;h=e06cb6d66db37ac7ab77acf65038b1f770c13c96
>> http://git.overlays.gentoo.org/gitweb/?p=proj/portage.git;a=commit;h=cbebf76d8e5666aad4984f87c2be83d474fe5a7e
>> http://git.overlays.gentoo.org/gitweb/?p=proj/portage.git;a=commit;h=13abe0398fbe724218c8c9ac2597ebe15d7db7e1
>>
>> I made a few trivial change in order to make them compatible with
>> python3. Also, I made it use the old behavior for protocols other than
>> http and https, in order to avoid issues with ftp like this one:
>>
>> https://bugs.gentoo.org/show_bug.cgi?id=415579
>>
>
> Fix python2 http password breakage:
>
> http://git.overlays.gentoo.org/gitweb/?p=proj/portage.git;a=commit;h=fbeb8101b20e232b2e8c55c9554b5fc9c5c72089
>
> BUG: The if_modified_since parameter appears to be ignored when using
> http password authentication.

Hi Zac,

In one word: Great! I love your modifications. Thank you!

Regarding functionality – there is still some room for more
optimizations and more features. For example, if the local copy is no
older than x seconds then there's no need to contact any remote
server. Expect patches.

As for the bug. As long as the "If-Modified-Since" header is sent
Portage has done its job. Some servers use the header as "ETag"
replacement and don't do the more costly greater-than comparison (see
also [1]; TIMESTAMP_TOLERANCE should be a configuration option so
users can set it to 0 now that the "mtime"-patch has been accepted).
And, BaseHandler are chained automatically by "build_opener".
Nevertheless, I will look into the whole issue the next days.

-- 
Grüße, Mark