Re: [gentoo-portage-dev] [PATCH] Implement --newrepo flag.

[David James <davidjames@google.com>]

[-- Attachment #1: Type: text/plain, Size: 1800 bytes --]

On Mon, Feb 17, 2014 at 12:09 PM, Sebastian Luther
<SebastianLuther@gmx.de>wrote:

> Am 17.02.2014 18:52, schrieb David James:
> > @@ -96,6 +105,68 @@ class MultirepoTestCase(TestCase):
> <snip>
> > +
> > +                     #--newrepo: pick ebuild if binpkg/ebuild have
> different repo
> > +                     ResolverPlaygroundTestCase(
> > +                             ["dev-libs/C"],
> > +                             options = {"--usepkg": True, "--newrepo":
> True, "--selective": True},
> > +                             success = True,
> > +                             check_repo_names = True,
> > +                             mergelist = ["dev-libs/C-1::repo1"]),
>
> Why should it take the ebuild from the repo with lower priority?
>
> I thought the intend was that the package should be reinstalled if it is
> now pulled from a repo with higher priority than the repo from which the
> installed package came.


Interesting idea -- but no, that's not what I implemented. The intent here
is that a package will be reinstalled if it is now pulled from a different
repo than the repo from which the installed package came. This is actually
an important difference for our use case -- it allows you to switch in both
directions, both to higher priority repos and to lower priority repos.

From a theoretical perspective, the reason why I implemented this is
because "ebuilds" are the source of truth. According to the ebuilds, the
owner repo of dev-libs/C-1 is repo1, so this means that, with --newrepo,
any binpkg for dev-libs/C-1 from repo2 would be invalid.

This functionality is useful in the case where an ebuild changes repos. In
this case, with --newrepo, you would want the package to be rebuilt and any
binaries to be invalidated, and our tests validate this.

Cheers,

David

[-- Attachment #2: Type: text/html, Size: 2557 bytes --]