public inbox for gentoo-portage-dev@lists.gentoo.org
 help / color / mirror / Atom feed
From: Matt Turner <mattst88@gentoo.org>
To: gentoo-portage-dev@lists.gentoo.org
Cc: Pin-yen Lin <treapking@chromium.org>
Subject: Re: [gentoo-portage-dev] [PATCH 2/2] Add caching to _slot_operator_check_reverse_dependencies
Date: Fri, 25 Nov 2022 12:08:52 -0500	[thread overview]
Message-ID: <CAEdQ38EH3+NwaZe5TBSaHVnUG8UdaSYFcE-5xqPAGEFG7aewPA@mail.gmail.com> (raw)
In-Reply-To: <20221125033627.1105638-2-treapking@chromium.org>

On Thu, Nov 24, 2022 at 10:36 PM Pin-yen Lin <treapking@chromium.org> wrote:
>
> Add lru_cache to speed up the running time of "Calculating
> dependencies".
>
> In a ChromeOS use case, this patch decreases the running time from
> 311s to 197s with almost no memory usage increase.
>
> Signed-off-by: Pin-yen Lin <treapking@chromium.org>

Thank you!

With recent subslot rebuilds (icu, boost, poppler), I measure an
improvement of 19%!

Benchmark 1: emerge @world -vuNDp
  Time (mean ± σ):     42.668 s ±  0.555 s    [User: 42.095 s, System: 0.315 s]
  Range (min … max):   41.572 s … 43.342 s    10 runs

Benchmark 2: emerge @world -vuNDp
  Time (mean ± σ):     35.991 s ±  0.154 s    [User: 35.409 s, System: 0.332 s]
  Range (min … max):   35.831 s … 36.306 s    10 runs

Summary
  'emerge @world -vuNDp' ran
    1.19 ± 0.02 times faster than 'emerge @world -vuNDp'


  reply	other threads:[~2022-11-25 17:09 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-25  3:36 [gentoo-portage-dev] [PATCH 1/2] Move and rename check_reverse_dependencies Pin-yen Lin
2022-11-25  3:36 ` [gentoo-portage-dev] [PATCH 2/2] Add caching to _slot_operator_check_reverse_dependencies Pin-yen Lin
2022-11-25 17:08   ` Matt Turner [this message]
2022-11-28 15:47   ` Zac Medico

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAEdQ38EH3+NwaZe5TBSaHVnUG8UdaSYFcE-5xqPAGEFG7aewPA@mail.gmail.com \
    --to=mattst88@gentoo.org \
    --cc=gentoo-portage-dev@lists.gentoo.org \
    --cc=treapking@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox