From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <gentoo-portage-dev+bounces-3261-garchives=archives.gentoo.org@lists.gentoo.org> Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id A8841138247 for <garchives@archives.gentoo.org>; Thu, 16 Jan 2014 17:24:56 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 21AAAE0B44; Thu, 16 Jan 2014 17:24:56 +0000 (UTC) Received: from mail-wg0-f45.google.com (mail-wg0-f45.google.com [74.125.82.45]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 69951E0B41 for <gentoo-portage-dev@lists.gentoo.org>; Thu, 16 Jan 2014 17:24:55 +0000 (UTC) Received: by mail-wg0-f45.google.com with SMTP id n12so3434154wgh.0 for <gentoo-portage-dev@lists.gentoo.org>; Thu, 16 Jan 2014 09:24:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:reply-to:sender:in-reply-to:references:date:message-id :subject:from:to:content-type; bh=bkcG0FWwl2Jz463Jd4BVy8S37enanVPejcmU9b7G9Og=; b=YmV9tjZkaGlwjBeyy6ILYSHwqO4hfBv6l4se97CkG3dtIceVf+APTgqkC1LWKzTj5B rWADxUMrLNcjWRt9SZWEMuoEQxscofwOup0XKBVIMcOyS5SvHQMK/PqA07V7gIuusAMJ yAMqKg0m5YoHGLk1FQeqPhXwN6XRmkvCJjfkDyMuT9MGvEqKxHCHjmGQQDpaEwdbacim nnIX1bKPQwJc6SttHWNj4B2hAcpWJhE8xDmYUVp60JlPlzf4NLYnPWMLovLjgoMdylN7 OqWGKiCiryJA+/77e9r5eNcnN0PBZxQ/YhHYo1jR9k+XUhv8YDYDxq0rxrkz0VkF5k8/ I7CA== Precedence: bulk List-Post: <mailto:gentoo-portage-dev@lists.gentoo.org> List-Help: <mailto:gentoo-portage-dev+help@lists.gentoo.org> List-Unsubscribe: <mailto:gentoo-portage-dev+unsubscribe@lists.gentoo.org> List-Subscribe: <mailto:gentoo-portage-dev+subscribe@lists.gentoo.org> List-Id: Gentoo Linux mail <gentoo-portage-dev.gentoo.org> X-BeenThere: gentoo-portage-dev@lists.gentoo.org Reply-to: gentoo-portage-dev@lists.gentoo.org MIME-Version: 1.0 X-Received: by 10.180.81.38 with SMTP id w6mr9004150wix.27.1389893094104; Thu, 16 Jan 2014 09:24:54 -0800 (PST) Sender: neurogeekster@gmail.com Received: by 10.216.83.206 with HTTP; Thu, 16 Jan 2014 09:24:54 -0800 (PST) In-Reply-To: <52D7DC9B.6050602@plaimi.net> References: <52D7DC9B.6050602@plaimi.net> Date: Thu, 16 Jan 2014 12:24:54 -0500 X-Google-Sender-Auth: 9XPhq1cRzMtJihNOIP4cXDpiuPo Message-ID: <CAD3zpDmL=GsdfoD+XrUK=sYnZLi7FP1cnTprC1tRbyfeT5diWQ@mail.gmail.com> Subject: Re: [gentoo-portage-dev] Signing off patches From: "Jesus Rivero (Neurogeek)" <neurogeek@gentoo.org> To: gentoo-portage-dev@lists.gentoo.org Content-Type: multipart/alternative; boundary=f46d044288c026665404f019b489 X-Archives-Salt: 4ba9552c-3e8e-493d-82a5-d3b4b7de81ad X-Archives-Hash: 20baa75d3f6a7a6f29e591ef9817362c --f46d044288c026665404f019b489 Content-Type: text/plain; charset=ISO-8859-1 On Thu, Jan 16, 2014 at 8:20 AM, Alexander Berntsen <alexander@plaimi.net>wrote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA256 > > We have quite a few dedicated developers now. To ensure that good > taste is exercised, and that best practices are followed, patches > should be signed. > > My proposals: > Signed-off-by: Wrote (a substantial portion of) the patch > Reviewed-by: Reviewed the patch thoroughly > Tested-by: Tested the patch thoroughly > Acked-by: Approved the concept but did not read the patch in detail > (typically used by the maintainer of a specific portion, or our lead) > Suggested-by: Designed the implementation > Reported-by: Reported the bug/feature request > > These suggestions all stem from the Linux project. > - -- > Alexander > alexander@plaimi.net > http://plaimi.net/~alexander > -----BEGIN PGP SIGNATURE----- > Version: GnuPG v2.0.22 (GNU/Linux) > Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ > > iF4EAREIAAYFAlLX3JsACgkQRtClrXBQc7VhEQD9FKmFbyf9zxl+hLylkhQN/kv6 > o3DSM4xBr9fH4+1eokYA/3MbFLtDpli311d6ZqGD17kGLfz5wNj+5kPRATbiC256 > =cJNe > -----END PGP SIGNATURE----- > > So, how would this work with emails to this list, exactly? An email should be sent any time one of those fields is changed? I think that would be overkill in our specific context. That makes much more sense if we had a CR tool, where changes to a patch could be seen in one place, and email passes to be only a 'notification tool'. Do you have a more detailed plan on how would this work? Cheers, -- Jesus Rivero (Neurogeek) Gentoo Developer --f46d044288c026665404f019b489 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable <div dir=3D"ltr"><br><div class=3D"gmail_extra"><br><br><div class=3D"gmail= _quote">On Thu, Jan 16, 2014 at 8:20 AM, Alexander Berntsen <span dir=3D"lt= r"><<a href=3D"mailto:alexander@plaimi.net" target=3D"_blank">alexander@= plaimi.net</a>></span> wrote:<br> <blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1p= x #ccc solid;padding-left:1ex">-----BEGIN PGP SIGNED MESSAGE-----<br> Hash: SHA256<br> <br> We have quite a few dedicated developers now. To ensure that good<br> taste is exercised, and that best practices are followed, patches<br> should be signed.<br> <br> My proposals:<br> Signed-off-by: Wrote (a substantial portion of) the patch<br> Reviewed-by: Reviewed the patch thoroughly<br> Tested-by: =A0Tested the patch thoroughly<br> Acked-by: Approved the concept but did not read the patch in detail<br> (typically used by the maintainer of a specific portion, or our lead)<br> Suggested-by: Designed the implementation<br> Reported-by: Reported the bug/feature request<br> <br> These suggestions all stem from the Linux project.<br> - --<br> Alexander<br> <a href=3D"mailto:alexander@plaimi.net">alexander@plaimi.net</a><br> <a href=3D"http://plaimi.net/~alexander" target=3D"_blank">http://plaimi.ne= t/~alexander</a><br> -----BEGIN PGP SIGNATURE-----<br> Version: GnuPG v2.0.22 (GNU/Linux)<br> Comment: Using GnuPG with Thunderbird - <a href=3D"http://www.enigmail.net/= " target=3D"_blank">http://www.enigmail.net/</a><br> <br> iF4EAREIAAYFAlLX3JsACgkQRtClrXBQc7VhEQD9FKmFbyf9zxl+hLylkhQN/kv6<br> o3DSM4xBr9fH4+1eokYA/3MbFLtDpli311d6ZqGD17kGLfz5wNj+5kPRATbiC256<br> =3DcJNe<br> -----END PGP SIGNATURE-----<br> <br> </blockquote></div><br>So, how would this work with emails to this list, ex= actly? An email should be sent any time one of those fields is changed?</di= v><div class=3D"gmail_extra">I think that would be overkill in our specific= context. That makes much more sense if we had a CR tool, where changes to = a patch could be seen in one place, and email passes to be only a 'noti= fication tool'.</div> <div class=3D"gmail_extra"><br></div><div class=3D"gmail_extra">Do you have= a more detailed plan on how would this work?</div><div class=3D"gmail_extr= a"><br></div><div class=3D"gmail_extra">Cheers,</div><div class=3D"gmail_ex= tra"><div> <br></div>-- <br>Jesus Rivero (Neurogeek)<br>Gentoo Developer </div></div> --f46d044288c026665404f019b489--