From: "Jesus Rivero (Neurogeek)" <neurogeek@gentoo.org>
To: gentoo-portage-dev@lists.gentoo.org
Subject: Re: [gentoo-portage-dev] Signing off patches
Date: Thu, 16 Jan 2014 12:24:54 -0500 [thread overview]
Message-ID: <CAD3zpDmL=GsdfoD+XrUK=sYnZLi7FP1cnTprC1tRbyfeT5diWQ@mail.gmail.com> (raw)
In-Reply-To: <52D7DC9B.6050602@plaimi.net>
[-- Attachment #1: Type: text/plain, Size: 1579 bytes --]
On Thu, Jan 16, 2014 at 8:20 AM, Alexander Berntsen <alexander@plaimi.net>wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA256
>
> We have quite a few dedicated developers now. To ensure that good
> taste is exercised, and that best practices are followed, patches
> should be signed.
>
> My proposals:
> Signed-off-by: Wrote (a substantial portion of) the patch
> Reviewed-by: Reviewed the patch thoroughly
> Tested-by: Tested the patch thoroughly
> Acked-by: Approved the concept but did not read the patch in detail
> (typically used by the maintainer of a specific portion, or our lead)
> Suggested-by: Designed the implementation
> Reported-by: Reported the bug/feature request
>
> These suggestions all stem from the Linux project.
> - --
> Alexander
> alexander@plaimi.net
> http://plaimi.net/~alexander
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v2.0.22 (GNU/Linux)
> Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/
>
> iF4EAREIAAYFAlLX3JsACgkQRtClrXBQc7VhEQD9FKmFbyf9zxl+hLylkhQN/kv6
> o3DSM4xBr9fH4+1eokYA/3MbFLtDpli311d6ZqGD17kGLfz5wNj+5kPRATbiC256
> =cJNe
> -----END PGP SIGNATURE-----
>
>
So, how would this work with emails to this list, exactly? An email should
be sent any time one of those fields is changed?
I think that would be overkill in our specific context. That makes much
more sense if we had a CR tool, where changes to a patch could be seen in
one place, and email passes to be only a 'notification tool'.
Do you have a more detailed plan on how would this work?
Cheers,
--
Jesus Rivero (Neurogeek)
Gentoo Developer
[-- Attachment #2: Type: text/html, Size: 2357 bytes --]
next prev parent reply other threads:[~2014-01-16 17:24 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-16 13:20 [gentoo-portage-dev] Signing off patches Alexander Berntsen
2014-01-16 16:41 ` Alec Warner
2014-01-16 17:02 ` Alexander Berntsen
2014-01-16 16:45 ` W. Trevor King
2014-01-16 17:05 ` Alexander Berntsen
2014-01-16 17:11 ` W. Trevor King
2014-01-16 17:37 ` Alexander Berntsen
2014-01-16 17:24 ` Jesus Rivero (Neurogeek) [this message]
2014-01-16 17:44 ` Alexander Berntsen
2014-01-16 17:57 ` Jesus Rivero (Neurogeek)
2014-01-16 19:54 ` [gentoo-portage-dev] " Duncan
2014-01-16 20:07 ` W. Trevor King
2014-01-16 21:12 ` Alexander Berntsen
2014-01-18 6:44 ` [gentoo-portage-dev] " Mike Frysinger
2014-01-18 15:02 ` Tom Wijsman
2014-01-18 16:43 ` W. Trevor King
2014-01-18 22:57 ` Tom Wijsman
2014-01-18 23:24 ` W. Trevor King
2014-01-19 1:33 ` Tom Wijsman
2014-01-19 4:15 ` W. Trevor King
2014-01-20 2:09 ` Tom Wijsman
2014-01-20 2:32 ` W. Trevor King
2014-01-21 15:40 ` Tom Wijsman
2014-01-21 16:51 ` W. Trevor King
2014-01-21 16:59 ` Tom Wijsman
2014-01-21 17:20 ` W. Trevor King
2014-01-21 18:41 ` Tom Wijsman
2014-01-21 19:18 ` W. Trevor King
2014-01-21 19:22 ` Tom Wijsman
2014-01-21 19:45 ` W. Trevor King
2014-01-19 8:57 ` Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAD3zpDmL=GsdfoD+XrUK=sYnZLi7FP1cnTprC1tRbyfeT5diWQ@mail.gmail.com' \
--to=neurogeek@gentoo.org \
--cc=gentoo-portage-dev@lists.gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox