From: "Jesus Rivero (Neurogeek)" <neurogeek@gentoo.org>
To: gentoo-portage-dev@lists.gentoo.org
Subject: Re: [gentoo-portage-dev] [PATCH 2/3] Have repoman check that a package directory contains at least one ebuild (bug #245305).
Date: Wed, 15 Jan 2014 20:07:16 -0500 [thread overview]
Message-ID: <CAD3zpDkz7_WdG8RUj+10XAFs-c-k82xGk3UUdGk8X136BN0caQ@mail.gmail.com> (raw)
In-Reply-To: <1389830840-25848-3-git-send-email-tomwij@gentoo.org>
[-- Attachment #1: Type: text/plain, Size: 2249 bytes --]
On Jan 15, 2014 7:09 PM, "Tom Wijsman" <tomwij@gentoo.org> wrote:
>
> ---
> bin/repoman | 8 ++++++++
> man/repoman.1 | 3 +++
> 2 files changed, 11 insertions(+)
>
> diff --git a/bin/repoman b/bin/repoman
> index 9b703dc..3263ceb 100755
> --- a/bin/repoman
> +++ b/bin/repoman
> @@ -330,6 +330,7 @@ qahelp = {
> "SRC_URI.mirror": "A uri listed in profiles/thirdpartymirrors is
found in SRC_URI",
> "ebuild.syntax": "Error generating cache entry for ebuild;
typically caused by ebuild syntax error or digest verification failure",
> "ebuild.output": "A simple sourcing of the ebuild produces
output; this breaks ebuild policy.",
> + "ebuild.missing": "A package directory must at least contain one
ebuild or be treecleaned.",
> "ebuild.nesteddie": "Placing 'die' inside ( ) prints an error,
but doesn't stop the ebuild.",
> "variable.invalidchar": "A variable contains an invalid character
that is not part of the ASCII character set",
> "variable.readonly": "Assigning a readonly variable",
> @@ -1466,6 +1467,13 @@ for x in effective_scanlist:
> can_force = False
> continue
>
> + if len(ebuildlist) == 0:
I'd rather see:
if not ebuildlist:
> + stats["ebuild.missing"] += 1
> + fails["ebuild.missing"].append("%s must at least contain
one " % x + \
> + "ebuild or be treecleaned.")
> + can_force = False
> + continue
> +
> # Sort ebuilds in ascending order for the KEYWORDS.dropped check.
> ebuildlist = sorted(pkgs.values())
> ebuildlist = [pkg.pf for pkg in ebuildlist]
> diff --git a/man/repoman.1 b/man/repoman.1
> index e739d56..2bf3765 100644
> --- a/man/repoman.1
> +++ b/man/repoman.1
> @@ -301,6 +301,9 @@ Ebuilds that exist but have not been added to cvs
> .B ebuild.output
> A simple sourcing of the ebuild produces output; this breaks ebuild
policy.
> .TP
> +.B ebuild.missing
> +A package directory must at least contain one ebuild or be treecleaned.
> +.TP
> .B ebuild.patches
> PATCHES variable should be a bash array to ensure white space safety
> .TP
> --
> 1.8.5.2
>
>
Everything else looks good to me.
Cheers,
[-- Attachment #2: Type: text/html, Size: 2996 bytes --]
next prev parent reply other threads:[~2014-01-16 1:07 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-16 0:07 [gentoo-portage-dev] Repoman patches for bugs #205909, #245305 and #482084 Tom Wijsman
2014-01-16 0:07 ` [gentoo-portage-dev] [PATCH 1/3] Have repoman check if the packages to unpack rare archive formats from SRC_URI are present in DEPEND (bug #205909) Tom Wijsman
2014-01-16 1:44 ` Alec Warner
2014-01-16 21:18 ` Tom Wijsman
2014-01-16 21:23 ` Alexander Berntsen
2014-01-16 21:52 ` Tom Wijsman
2014-01-16 22:22 ` Alexander Berntsen
2014-01-16 23:02 ` Tom Wijsman
2014-01-17 6:14 ` Alec Warner
2014-01-17 23:35 ` Tom Wijsman
2014-01-17 0:33 ` Tom Wijsman
2014-01-16 7:03 ` Sebastian Luther
2014-01-16 21:40 ` Tom Wijsman
2014-01-17 8:35 ` Sebastian Luther
2014-01-17 23:00 ` Tom Wijsman
2014-01-18 6:49 ` Sebastian Luther
2014-01-17 8:28 ` Sebastian Luther
2014-01-17 16:40 ` Tom Wijsman
2014-01-17 23:03 ` [gentoo-portage-dev] [PATCH 1/3 v2] " Tom Wijsman
2014-01-19 9:38 ` Mike Frysinger
2014-01-20 2:23 ` Tom Wijsman
2014-01-20 2:43 ` Alec Warner
2014-01-21 15:32 ` Tom Wijsman
2014-01-16 0:07 ` [gentoo-portage-dev] [PATCH 2/3] Have repoman check that a package directory contains at least one ebuild (bug #245305) Tom Wijsman
2014-01-16 1:07 ` Jesus Rivero (Neurogeek) [this message]
2014-01-16 1:45 ` Alec Warner
2014-01-17 21:36 ` [gentoo-portage-dev] [PATCH 2/3 v2] " Tom Wijsman
2014-01-17 22:34 ` Jesus Rivero (Neurogeek)
2014-01-16 0:07 ` [gentoo-portage-dev] [PATCH 3/3] Have repoman deprecate G2CONF for the GNOME team. (bug #482084) Tom Wijsman
2014-01-16 1:23 ` Jesus Rivero (Neurogeek)
2014-01-16 21:56 ` Tom Wijsman
2014-01-19 9:26 ` Mike Frysinger
2014-01-19 9:28 ` Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAD3zpDkz7_WdG8RUj+10XAFs-c-k82xGk3UUdGk8X136BN0caQ@mail.gmail.com \
--to=neurogeek@gentoo.org \
--cc=gentoo-portage-dev@lists.gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox