From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id 850CF138247 for ; Sun, 19 Jan 2014 21:43:40 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 15F0DE0E3C; Sun, 19 Jan 2014 21:43:40 +0000 (UTC) Received: from mail-we0-f173.google.com (mail-we0-f173.google.com [74.125.82.173]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 45DBDE0E3A for ; Sun, 19 Jan 2014 21:43:38 +0000 (UTC) Received: by mail-we0-f173.google.com with SMTP id t60so6285458wes.18 for ; Sun, 19 Jan 2014 13:43:37 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:date :message-id:subject:from:to:content-type; bh=B1Zxz53qiKnq5/FcNGkeyK3cLCqciRTA22qUOG6fArc=; b=lK9NXEhp2VsFKVRx/W0LtlZXkyWtwBgd5Fc0LnORSopqx/ysBCEda+TYKtv2D6QGQV sUf3tw9hm1x0GnYzT5fLCfN+Ni4M9q9RKoB0fJnAySn3GegiKkyfGnWRRmsA5Ab+CTYR F5stNeZSL3XfIfpiuMkY9SW/2DCGxQTIelEUBSpeyDCcmMgyNMJbx1pyClR19XzTCqgh KfrObJZ3Gtcz/VRthPXqI1X/o9OX9Wa5PXr4nW5lnmS/2eb9smK7rXP5V+eRjRm4VWtq Gi2dda9H2msLMgZY4rYXEIGwosMrboPW0OrwCfRMNr3ADO9HFMAgkVNlxLkTMFpodCeh Pk+g== X-Gm-Message-State: ALoCoQmJ2HSvoPau0y76lhNd8Hc73y/ya4lG4bXG5vuBFno60OIHMvfcUzYomKbEdjFNLMykdbPt Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-portage-dev@lists.gentoo.org Reply-to: gentoo-portage-dev@lists.gentoo.org MIME-Version: 1.0 X-Received: by 10.180.21.166 with SMTP id w6mr7164033wie.31.1390167817817; Sun, 19 Jan 2014 13:43:37 -0800 (PST) Sender: antarus@scriptkitty.com Received: by 10.216.170.129 with HTTP; Sun, 19 Jan 2014 13:43:37 -0800 (PST) X-Originating-IP: [173.8.165.226] In-Reply-To: <52DBAB5D.3030802@plaimi.net> References: <1389919144-30969-1-git-send-email-creffett@gentoo.org> <1390096848-28010-1-git-send-email-creffett@gentoo.org> <201401190417.41690.vapier@gentoo.org> <52DBAB5D.3030802@plaimi.net> Date: Sun, 19 Jan 2014 13:43:37 -0800 X-Google-Sender-Auth: 1GzqDl8jVqJqj7FqgDWaSEq94zY Message-ID: Subject: Re: [gentoo-portage-dev] [PATCH v3] Test for read-only filesystems, bail out during preinst if there are any which will be written to and display a useful error message. Fixes bug 378869. From: Alec Warner To: gentoo-portage-dev@lists.gentoo.org Content-Type: multipart/alternative; boundary=047d7b6d9a86f5a35604f059aac3 X-Archives-Salt: c26fc8f7-de2f-4cf9-afbe-7605e3959c08 X-Archives-Hash: 4a2a6a28752a818e43b2e1e88c1e3e71 --047d7b6d9a86f5a35604f059aac3 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Sun, Jan 19, 2014 at 2:39 AM, Alexander Berntsen w= rote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA256 > > On 19/01/14 10:17, Mike Frysinger wrote: > > prefer OSes -> OS's > That's just not proper English. It makes no sense. Please don't prefer > that. If for nothing else, then to prevent me from sighing whenever I > have to read it. > The bikeshed should be red! Be happy in the fact that this bit has no significant bearing on the code and just pick one. > > not a new issue, but we really need to get away from this style and > > use PEP257. someone feel like fixing that in the code base ? :) > I agree. If you give me at least a week (won't have time until next > weekend), I can look into it. > Sorry, my fault. I added docstrings in 2006 (looks like the first one was vercmp in http://git.overlays.gentoo.org/gitweb/?p=3Dproj/portage.git;a=3Dblobdiff;f= =3Dpym/portage_versions.py;h=3D8e58c2f47766c0ed6c007c0cba1fccebca7d4eb4;hp= =3Dec01773ad199a87d7906eb3862a14b9c8102fc29;hb=3Dcfc497009e6054a5403461be67= 6bb94deebbbf50;hpb=3D53f14db70339391fb13ca0adab353645f84be3f2) I'm happy for these to change. ;p -A > - -- Alexander > alexander@plaimi.net > http://plaimi.net/~alexander > -----BEGIN PGP SIGNATURE----- > Version: GnuPG v2.0.22 (GNU/Linux) > Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ > > iF4EAREIAAYFAlLbq10ACgkQRtClrXBQc7U7MAD/Yl2pd0ood3UKmvNMg9gdWMsw > hQqnReHPRwLpDNRccOcA/jUODDanycVmNLpD/rjkYnKyllnbUSIxduYuMcJFqXme > =3DvaDs > -----END PGP SIGNATURE----- > > --047d7b6d9a86f5a35604f059aac3 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
On S= un, Jan 19, 2014 at 2:39 AM, Alexander Berntsen <alexander@plaimi.net> wrote:
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

On 19/01/14 10:17, Mike Frysinger wrote:
> prefer OSes -> OS's
That's just not proper English. It makes no sense. Please don'= ;t prefer
that. If for nothing else, then to prevent me from sighing whenever I
have to read it.

The bikeshed should be= red! Be happy in the fact that this bit has no significant bearing on the = code and just pick one.


> not a new issue, but we really need to get away from this style and > use PEP257. =C2=A0someone feel like fixing that in the code base ? :)<= br>
I agree. If you give me at least a week (won't have time until ne= xt
weekend), I can look into it.

-A

=C2=A0
- --=C2=A0
Alexander
alexander@plaimi.net
http://plaimi.ne= t/~alexander
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.22 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iF4EAREIAAYFAlLbq10ACgkQRtClrXBQc7U7MAD/Yl2pd0ood3UKmvNMg9gdWMsw
hQqnReHPRwLpDNRccOcA/jUODDanycVmNLpD/rjkYnKyllnbUSIxduYuMcJFqXme
=3DvaDs
-----END PGP SIGNATURE-----


--047d7b6d9a86f5a35604f059aac3--