* Re: [gentoo-portage-dev] [PATCH] Output uniform status message before and after src_test()
@ 2014-08-17 13:02 99% ` Alexander Berntsen
0 siblings, 0 replies; 1+ results
From: Alexander Berntsen @ 2014-08-17 13:02 UTC (permalink / raw
To: gentoo-portage-dev
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
On 17/08/14 00:22, Michał Górny wrote:
> Before, the status message indicating src_test() run was output
> only if the default EAPI implementation was used. If an ebuild
> overrode test phase, the test phase output lacked delimitation.
> Instead, output uniform status messages before and after running
> src_test() alike for other phase functions.
Does this actually fix anything or matter to anyone? It looks fine to
me, but seeing as there's no bug, I'm not sure it's actually fixing
anything.
Also, for the commit message, remember what we talked about with
active sentences. Write "Do Foo to solve Bar", rather than "Bar is a
problem. Here is a lengthy paragraph about that with a fix, Foo,
somewhere at the end -- hope you don't miss it!".
- --
Alexander
bernalex@gentoo.org
https://secure.plaimi.net/~alexander
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/
iF4EAREIAAYFAlPwp9UACgkQRtClrXBQc7XT0QEAjSQuUGkU84YKxtkIC4b/qSIN
Iek0NB1dN1QV9eV52bQA/3SSgT/WJPjqAt9kz1xa+mrDENaGcYLsKLpHdOhjqhTb
=5r99
-----END PGP SIGNATURE-----
^ permalink raw reply [relevance 99%]
Results 1-1 of 1 | reverse | options above
-- pct% links below jump to the message on this page, permalinks otherwise --
2014-08-16 22:22 [gentoo-portage-dev] [PATCH] Output uniform status message before and after src_test() Michał Górny
2014-08-17 13:02 99% ` Alexander Berntsen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox