* Re: [gentoo-portage-dev] [PATCH] Fix off-by-one error in supported EAPI list
@ 2014-08-17 18:44 99% ` Brian Dolbec
0 siblings, 0 replies; 1+ results
From: Brian Dolbec @ 2014-08-17 18:44 UTC (permalink / raw
To: gentoo-portage-dev
On Sun, 17 Aug 2014 20:37:10 +0200
Michał Górny <mgorny@gentoo.org> wrote:
> Fix the off-by-one error in construction of supported EAPI list that
> resulted in EAPI 5 being considered unsupported.
> ---
> pym/portage/__init__.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/pym/portage/__init__.py b/pym/portage/__init__.py
> index fdbc4a8..18b2599 100644
> --- a/pym/portage/__init__.py
> +++ b/pym/portage/__init__.py
> @@ -493,7 +493,7 @@ _doebuild_manifest_exempt_depend = 0
>
> _testing_eapis = frozenset(["4-python", "4-slot-abi", "5-progress",
> "5-hdepend"]) _deprecated_eapis = frozenset(["4_pre1", "3_pre2",
> "3_pre1", "5_pre1", "5_pre2"]) -_supported_eapis = frozenset([str(x)
> for x in range(portage.const.EAPI)] + list(_testing_eapis) +
> list(_deprecated_eapis)) +_supported_eapis = frozenset([str(x) for x
> in range(portage.const.EAPI + 1)] + list(_testing_eapis) +
> list(_deprecated_eapis)) def _eapi_is_deprecated(eapi): return eapi
> in _deprecated_eapis
Hmm, I thought EAPI was suppose to be a string...
from portage/const.py:
EAPI = 5
which is clearly an integer.
Shouldn't it be a list of supported EAPI's if it is a string?
Then you'd also have to change the range() use to a len of EAPI.split()
--
Brian Dolbec <dolsen>
^ permalink raw reply [relevance 99%]
Results 1-1 of 1 | reverse | options above
-- pct% links below jump to the message on this page, permalinks otherwise --
2014-08-17 18:37 [gentoo-portage-dev] [PATCH] Fix off-by-one error in supported EAPI list Michał Górny
2014-08-17 18:44 99% ` Brian Dolbec
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox