* Re: [gentoo-portage-dev] [PATCH] Add repoman check to warn if src_prepare/src_configure are used in EAPI 0/1
@ 2014-01-14 0:50 99% ` Mike Frysinger
0 siblings, 0 replies; 1+ results
From: Mike Frysinger @ 2014-01-14 0:50 UTC (permalink / raw
To: gentoo-portage-dev; +Cc: creffett
[-- Attachment #1: Type: Text/Plain, Size: 809 bytes --]
On Monday 13 January 2014 19:08:30 creffett@gentoo.org wrote:
> From: Chris Reffett <creffett@gentoo.org>
you might want to set ~/.gitconfig to have your name/email so that git
sendemail uses the right info in the actual e-mail From: field
> + undefined_phases_re =
> re.compile(r'^\s*(src_configure|src_prepare)\s*\(\)')
you use re.match, so technically the ^ is redundant
i'd suggest merging the regex a little:
r'^\ssrc_(configure|prepare)\s*\(\)'
could check for pkg_pretend/pkg_info too (it's new to EAPI 4)
the regex is naive and can match valid ebuilds. consider ones that handle
$EAPI itself and will call the right funcs as necessary. can you check the
tree to see if anyone is doing this ? if so, we should drop a note to the dev
list and get them fixed up.
-mike
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [relevance 99%]
Results 1-1 of 1 | reverse | options above
-- pct% links below jump to the message on this page, permalinks otherwise --
2014-01-14 0:08 [gentoo-portage-dev] [PATCH] Add repoman check to warn if src_prepare/src_configure are used in EAPI 0/1 creffett
2014-01-14 0:50 99% ` Mike Frysinger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox