* Re: [gentoo-portage-dev] Signing off patches
@ 2014-01-21 15:40 99% ` Tom Wijsman
0 siblings, 0 replies; 1+ results
From: Tom Wijsman @ 2014-01-21 15:40 UTC (permalink / raw
To: wking; +Cc: gentoo-portage-dev
[-- Attachment #1: Type: text/plain, Size: 1587 bytes --]
On Sun, 19 Jan 2014 18:32:35 -0800
"W. Trevor King" <wking@tremily.us> wrote:
> If the initial submission does not express the consensus, you can
> either ask for a resubmission that does, or say “Alice, is it ok if I
> change your commit message to read ‘…’? when I commit it?”.
This assumes the committer would ask that, which barely happens.
Also, history rewriting is not acceptable as far as I know...
> No policy/suggestion/goal is going to be followed 100% of the time.
This way, it seems preferable to use the mailing list when blaming.
> If most commits, especially those that were contentious enough to go
> through a few rounds of revision, have a commit message with a good
> summary, then the future developer using blame has good odds of
> finding something useful. I think that's a good goal to shoot for,
> even if you don't hit it all the time.
The only realistic way to obtain this is to make it policy, or at
least make it checked as part of the review process; now neither
appears present, hence using blame has good odds of something useless.
> Even if you only consider the present, improving your commit message
> to address tricky implementation details or unclear motivation before
> submitting the next revision on a patch series will help reviewers
> understand your patch better in the first place.
+1
--
With kind regards,
Tom Wijsman (TomWij)
Gentoo Developer
E-mail address : TomWij@gentoo.org
GPG Public Key : 6D34E57D
GPG Fingerprint : C165 AF18 AB4C 400B C3D2 ABF0 95B2 1FCD 6D34 E57D
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 490 bytes --]
^ permalink raw reply [relevance 99%]
Results 1-1 of 1 | reverse | options above
-- pct% links below jump to the message on this page, permalinks otherwise --
2014-01-16 17:24 [gentoo-portage-dev] Signing off patches Jesus Rivero (Neurogeek)
2014-01-16 17:44 ` Alexander Berntsen
2014-01-18 6:44 ` Mike Frysinger
2014-01-18 15:02 ` Tom Wijsman
2014-01-18 16:43 ` W. Trevor King
2014-01-18 22:57 ` Tom Wijsman
2014-01-18 23:24 ` W. Trevor King
2014-01-19 1:33 ` Tom Wijsman
2014-01-19 4:15 ` W. Trevor King
2014-01-20 2:09 ` Tom Wijsman
2014-01-20 2:32 ` W. Trevor King
2014-01-21 15:40 99% ` Tom Wijsman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox