* [gentoo-portage-dev] [PATCH v3 0/4] Initial fetch() refactoring
@ 2014-01-20 3:26 99% ` W. Trevor King
0 siblings, 0 replies; 1+ results
From: W. Trevor King @ 2014-01-20 3:26 UTC (permalink / raw
To: gentoo-portage-dev; +Cc: Rafael Goncalves Martins, W. Trevor King
Changes since v2:
* Use """<summary>""" for one-line docstrings.
* Terminate docstring summaries with periods.
* Mention 'netloc' in _expand_mirror docstring.
* Uppercase URI in docstrings.
* Add a 'key' variable to cut down on setting-name noise.
* Remove parens and line extensions (\) from % formatting.
* Use 'expanded_uris' instead of 'uris' for _expand_mirror return
value.
* Additional line wrapping to stay under 80 chars.
* New test_fetch.py test suite for the helper functions.
* New patch #4 that refactors _get_fetch_resume_size.
Not changed since v2:
* Default arguments for _get_uris [1], but I've added an explicit
defense in my commit message.
* Use of settings in _get_uris [2], but I've added an explicit defense
in my commit message.
* Streamlining settings extraction [2], which I'm kicking down the
road. I think Portage should just use ConfigParser for settings,
but that is clearly outside the scope of this series.
Cheers,
Trevor
[1]: http://thread.gmane.org/gmane.linux.gentoo.portage.devel/4002/focus=4041
[2]: http://thread.gmane.org/gmane.linux.gentoo.portage.devel/4002/focus=4042
W. Trevor King (4):
pym/portage/package/ebuild/fetch.py: Factor out
_get_checksum_failure_max_tries
pym/portage/package/ebuild/fetch.py: Factor out _get_fetch_resume_size
pym/portage/package/ebuild/fetch.py: Factor out _get_uris
pym/portage/package/ebuild/fetch.py: Flatten conditionals in
_get_fetch_resume_size
pym/portage/package/ebuild/fetch.py | 318 ++++++++++++++++++++-------------
pym/portage/tests/ebuild/test_fetch.py | 203 +++++++++++++++++++++
2 files changed, 392 insertions(+), 129 deletions(-)
create mode 100644 pym/portage/tests/ebuild/test_fetch.py
--
1.8.5.2.8.g0f6c0d1
^ permalink raw reply [relevance 99%]
Results 1-1 of 1 | reverse | options above
-- pct% links below jump to the message on this page, permalinks otherwise --
2014-01-19 22:14 [gentoo-portage-dev] [PATCH v2 0/3] Initial fetch() refactoring W. Trevor King
2014-01-20 3:26 99% ` [gentoo-portage-dev] [PATCH v3 0/4] " W. Trevor King
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox