* Re: [gentoo-portage-dev] [PATCH v3] Copy files/* into the work tree instead of symlinking it
@ 2021-09-27 10:49 99% ` Ulrich Mueller
0 siblings, 0 replies; 1+ results
From: Ulrich Mueller @ 2021-09-27 10:49 UTC (permalink / raw
To: Michał Górny; +Cc: gentoo-portage-dev
[-- Attachment #1: Type: text/plain, Size: 1285 bytes --]
>>>>> On Sun, 26 Sep 2021, Michał Górny wrote:
> Symlinking FILESDIR into the work tree has the unintended consequence
> of preserving all original file metadata, including system-specific ACLs
> and so on. When these files are installed, this could lead to
> unintentionally copying this metadata to the system and/or binary
> packages.
> Let's copy all files instead and drop metadata in the process. Since
> FILESDIR is expected to be small by design, this shouldn't cause any
> major trouble. It is also easier and less likely to cause regressions
> than making sure stuff is not preserved when installing.
> Unfortunately, a similar problem applies to DISTDIR. However,
> installing files from DISTDIR is rarer than from FILESDIR, so I guess
> we'll cross that bridge when we get to it.
Sorry for the late reply, but this looks like the wrong solution to me.
Looking at the installation helpers (doins, doexe, etc.), they don't
preserve the normal permission bits, but reset them to a defined state.
So why would they preserve xattrs?
I don't see anything in PMS that would mandate that behaviour (on the
contrary, in section 13.3.1 there is "Other file attributes may be
discarded"). How do the other package managers handle this?
Ulrich
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 507 bytes --]
^ permalink raw reply [relevance 99%]
Results 1-1 of 1 | reverse | options above
-- pct% links below jump to the message on this page, permalinks otherwise --
2021-09-26 10:20 [gentoo-portage-dev] [PATCH v3] Copy files/* into the work tree instead of symlinking it Michał Górny
2021-09-27 10:49 99% ` Ulrich Mueller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox