* Re: [gentoo-portage-dev] [PATCH 0/3] Initial fetch() refactoring
@ 2014-01-22 5:34 99% ` Mike Frysinger
0 siblings, 0 replies; 1+ results
From: Mike Frysinger @ 2014-01-22 5:34 UTC (permalink / raw
To: gentoo-portage-dev; +Cc: Alec Warner
[-- Attachment #1: Type: Text/Plain, Size: 1075 bytes --]
On Sunday 19 January 2014 17:46:36 Alec Warner wrote:
> On Sun, Jan 19, 2014 at 2:45 PM, Alexander Berntsen wrote:
> > On 19/01/14 22:22, Sebastian Luther wrote:
> > > The usual doc string style used in portage is:
> > >
> > > """ text """
> > >
> > > Please use that for new functions. Also make sure you don't use
> > > spaces to indent the last """.
> >
> > As mentioned by Mike in another thread, we should use PEP 257[0]. I
> > will convert old code to conform to this... sometime... soon... (I
> > promise!)
> >
> > So if new patches could just do that right away, that would be neat.
>
> Does pylint or pyflakes point out if you mess it up?
>
> Automation for the win.
the good news is that i wrote a pylintrc module for Chromium OS to enforce
docstring style. the bad news is that it doesn't work with pyflakes.
https://chromium.googlesource.com/chromiumos/chromite/+/master/cros/commands/lint.py
what we did there was just merge it and then have people fix things up as they
went rather than try to clean it all up first.
-mike
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [relevance 99%]
Results 1-1 of 1 | reverse | options above
-- pct% links below jump to the message on this page, permalinks otherwise --
2014-01-19 3:07 [gentoo-portage-dev] [PATCH 0/3] Initial fetch() refactoring W. Trevor King
2014-01-19 22:45 ` Alexander Berntsen
2014-01-19 22:46 ` Alec Warner
2014-01-22 5:34 99% ` Mike Frysinger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox