* Re: [gentoo-portage-dev] [PATCH] repoman.modules.vcs.git.changes: reindex (bug 712106)
@ 2020-03-11 17:12 99% ` Zac Medico
0 siblings, 0 replies; 1+ results
From: Zac Medico @ 2020-03-11 17:12 UTC (permalink / raw
To: gentoo-portage-dev, Alec Warner
[-- Attachment #1.1: Type: text/plain, Size: 1676 bytes --]
On 3/11/20 9:37 AM, Alec Warner wrote:
> On Wed, Mar 11, 2020 at 12:16 AM Zac Medico <zmedico@gentoo.org
> <mailto:zmedico@gentoo.org>> wrote:
>
> For files returned by git diff-index, call git update-index in order
> to ensure that the index reflects the state on disk. This will prevent
> incorrect assumptions in cases where the index is missing or stale for
> some reason. Since repoman uses this information to decide when to
> update copyright header dates, this can prevent spurious copyright
> header updates.
>
> Signed-off-by: Zac Medico <zmedico@gentoo.org
> <mailto:zmedico@gentoo.org>>
> Bug: https://bugs.gentoo.org/712106
> ---
> repoman/lib/repoman/modules/vcs/git/changes.py | 15 ++++++++++++---
> 1 file changed, 12 insertions(+), 3 deletions(-)
>
> diff --git a/repoman/lib/repoman/modules/vcs/git/changes.py
> b/repoman/lib/repoman/modules/vcs/git/changes.py
> index 7e9ac1eb5..ebf770d53 100644
> --- a/repoman/lib/repoman/modules/vcs/git/changes.py
> +++ b/repoman/lib/repoman/modules/vcs/git/changes.py
> @@ -29,8 +29,14 @@ class Changes(ChangesBase):
> '''
> super(Changes, self).__init__(options, repo_settings)
>
> - def _scan(self):
> - '''VCS type scan function, looks for all detectable
> changes'''
> + def _scan(self, _reindex=True):
>
>
> Why the underscore prefix?
>
> -A
I can't think of a reason to use this parameter aside from this
recursive call, and the underscore hints at this.
--
Thanks,
Zac
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 981 bytes --]
^ permalink raw reply [relevance 99%]
Results 1-1 of 1 | reverse | options above
-- pct% links below jump to the message on this page, permalinks otherwise --
2020-03-11 7:13 [gentoo-portage-dev] [PATCH] repoman.modules.vcs.git.changes: reindex (bug 712106) Zac Medico
2020-03-11 16:37 ` Alec Warner
2020-03-11 17:12 99% ` Zac Medico
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox