* Re: [gentoo-portage-dev] Signing off patches
@ 2014-01-21 16:59 99% ` Tom Wijsman
0 siblings, 0 replies; 1+ results
From: Tom Wijsman @ 2014-01-21 16:59 UTC (permalink / raw
To: wking; +Cc: gentoo-portage-dev
[-- Attachment #1: Type: text/plain, Size: 1667 bytes --]
On Tue, 21 Jan 2014 08:51:14 -0800
"W. Trevor King" <wking@tremily.us> wrote:
> On Tue, Jan 21, 2014 at 04:40:19PM +0100, Tom Wijsman wrote:
> > On Sun, 19 Jan 2014 18:32:35 -0800 W. Trevor King wrote:
> > > If the initial submission does not express the consensus, you can
> > > either ask for a resubmission that does, or say “Alice, is it ok
> > > if I change your commit message to read ‘…’? when I commit it?”.
> >
> > This assumes the committer would ask that, which barely happens.
>
> If neither the committer nor the author feel like checking for this,
> it's probably not going to happen ;).
>
> > Also, history rewriting is not acceptable as far as I know...
>
> It's not rewriting history if the patch hasn't been pushed to a stable
> branch yet. When you commit the patch, adjusting it in ways that the
> author has agreed to shouldn't count as “rewriting history”. It's
> only rewriting after you've pushed the original patch into a stable
> branch.
>
> > > No policy/suggestion/goal is going to be followed 100% of the
> > > time.
> >
> > This way, it seems preferable to use the mailing list when blaming.
>
> Unless some of the discussion happened on IRC. There are several
> possible channels for patch discussion, but only one commit message
> per patch.
Exactly, without knowledge codification all that will continue to be
a "feel like", "probably not", "shouldn't", "unless some".
--
With kind regards,
Tom Wijsman (TomWij)
Gentoo Developer
E-mail address : TomWij@gentoo.org
GPG Public Key : 6D34E57D
GPG Fingerprint : C165 AF18 AB4C 400B C3D2 ABF0 95B2 1FCD 6D34 E57D
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 490 bytes --]
^ permalink raw reply [relevance 99%]
Results 1-1 of 1 | reverse | options above
-- pct% links below jump to the message on this page, permalinks otherwise --
2014-01-18 6:44 [gentoo-portage-dev] Signing off patches Mike Frysinger
2014-01-18 15:02 ` Tom Wijsman
2014-01-18 16:43 ` W. Trevor King
2014-01-18 22:57 ` Tom Wijsman
2014-01-18 23:24 ` W. Trevor King
2014-01-19 1:33 ` Tom Wijsman
2014-01-19 4:15 ` W. Trevor King
2014-01-20 2:09 ` Tom Wijsman
2014-01-20 2:32 ` W. Trevor King
2014-01-21 15:40 ` Tom Wijsman
2014-01-21 16:51 ` W. Trevor King
2014-01-21 16:59 99% ` Tom Wijsman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox