* Re: [gentoo-portage-dev] [PATCH] repoman: Remove http compatibility code for metadata DTD
@ 2022-01-29 17:25 99% ` Zac Medico
0 siblings, 0 replies; 1+ results
From: Zac Medico @ 2022-01-29 17:25 UTC (permalink / raw
To: gentoo-portage-dev, Ulrich Müller
[-- Attachment #1.1: Type: text/plain, Size: 1197 bytes --]
On 1/25/22 08:44, Ulrich Müller wrote:
> Commit 3950d76df says: "The http:// compat can be removed once the
> Gentoo repository is updated to use https:// everywhere."
>
> Bug: https://bugs.gentoo.org/552720
> Signed-off-by: Ulrich Müller <ulm@gentoo.org>
> ---
> repoman/lib/repoman/modules/scan/metadata/pkgmetadata.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/repoman/lib/repoman/modules/scan/metadata/pkgmetadata.py b/repoman/lib/repoman/modules/scan/metadata/pkgmetadata.py
> index b4e0ee933..0fb97a0df 100644
> --- a/repoman/lib/repoman/modules/scan/metadata/pkgmetadata.py
> +++ b/repoman/lib/repoman/modules/scan/metadata/pkgmetadata.py
> @@ -127,7 +127,7 @@ class PkgMetadata(ScanBase, USEFlagChecks):
> )
> else:
> doctype_system = _metadata_xml.docinfo.system_url
> - if doctype_system.replace("http://", "https://") != metadata_dtd_uri:
> + if doctype_system != metadata_dtd_uri:
> if doctype_system is None:
> system_problem = "but it is undefined"
> else:
Looks good. Please merge.
--
Thanks,
Zac
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 840 bytes --]
^ permalink raw reply [relevance 99%]
Results 1-1 of 1 | reverse | options above
-- pct% links below jump to the message on this page, permalinks otherwise --
2022-01-25 16:44 [gentoo-portage-dev] [PATCH] repoman: Remove http compatibility code for metadata DTD Ulrich Müller
2022-01-29 17:25 99% ` Zac Medico
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox