* [gentoo-portage-dev] [PATCH v2] eend: Output QA notice when called without argument
@ 2021-09-04 7:48 99% ` Ulrich Müller
0 siblings, 0 replies; 1+ results
From: Ulrich Müller @ 2021-09-04 7:48 UTC (permalink / raw
To: gentoo-portage-dev; +Cc: Ulrich Müller
PMS says about eend: "Takes one fixed argument, which is a numeric
return code, and an optional message in all subsequent arguments."
Bug: https://bugs.gentoo.org/703520
Signed-off-by: Ulrich Müller <ulm@gentoo.org>
---
bin/isolated-functions.sh | 1 +
1 file changed, 1 insertion(+)
diff --git a/bin/isolated-functions.sh b/bin/isolated-functions.sh
index b495ae6c7..5630dcf4c 100644
--- a/bin/isolated-functions.sh
+++ b/bin/isolated-functions.sh
@@ -364,6 +364,7 @@ __eend() {
}
eend() {
+ [[ -n $1 ]] || eqawarn "QA Notice: eend called without first argument"
local retval=${1:-0}
shift
--
2.33.0
^ permalink raw reply related [relevance 99%]
Results 1-1 of 1 | reverse | options above
-- pct% links below jump to the message on this page, permalinks otherwise --
2021-09-03 18:14 [gentoo-portage-dev] [PATCH] eend: Output QA notice when called without argument Michał Górny
2021-09-04 7:48 99% ` [gentoo-portage-dev] [PATCH v2] " Ulrich Müller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox