* Re: [gentoo-portage-dev] [PATCHES] @changed-deps + missing slot check reposted for bernalex
@ 2014-08-13 21:09 99% ` Alexander Berntsen
0 siblings, 0 replies; 1+ results
From: Alexander Berntsen @ 2014-08-13 21:09 UTC (permalink / raw
To: gentoo-portage-dev
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
These look good. ACK on 1 and 2 from me, but I would like Sebastian,
Arfrever, Brian, or someone else at least to look over them. These
patches are too "interesting" to be pushed after a single ACK.
For 3, I think it looks nice but you should check with Brian & Tom
about whether to put it in now or in the refactor branch. Also, please
ask QA about it so we don't get another bikeshed marathon to deal with.
Lastly, I think the commit message of the first commit is very poorly
worded, but we've discussed that on IRC. Ping me there for more
details if you want.
Thanks for doing this!
- --
Alexander
bernalex@gentoo.org
https://secure.plaimi.net/~alexander
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/
iF4EAREIAAYFAlPr1B4ACgkQRtClrXBQc7VG7gEAllXiY0FUKn+5dUajk/tiZoj/
3H3KW9MPfmfeMh0Dnv8BAJX+y8hsBnppm9W+ap8VfzkrxGeme6J6VSAdYCQd+Dea
=VX87
-----END PGP SIGNATURE-----
^ permalink raw reply [relevance 99%]
Results 1-1 of 1 | reverse | options above
-- pct% links below jump to the message on this page, permalinks otherwise --
2014-08-13 17:20 [gentoo-portage-dev] [PATCHES] @changed-deps + missing slot check reposted for bernalex Michał Górny
2014-08-13 21:09 99% ` Alexander Berntsen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox