* Re: [gentoo-portage-dev] equery: deprecate --category filtering in belongs
@ 2009-02-08 7:05 99% ` Douglas Anderson
0 siblings, 0 replies; 1+ results
From: Douglas Anderson @ 2009-02-08 7:05 UTC (permalink / raw
To: gentoo-portage-dev
On Sun, Feb 8, 2009 at 3:30 PM, Brian Harring <ferringb@gmail.com> wrote:
> patch attached against 0.2.4.2-r1; rough stats follow;
[snip]
> Mind you this isn't multiple runs, so the numbers are rough
> approximations- that said they're fairly representative.
>
> Strongly suggest y'all keep category support (although I'll keep on
> using pquery instead ;).
>
> Cheers,
> ~harring
>
Heh, OK I was looking at my local version of equery where category
filtering IS enabled while I was running tests with old equery, which
doesn't have it enabled. Thanks for pointing out my stupid mistake,
Brian. :)
We can in fact even make it go faster by filtering only cat/pkg before
it goes through cp_list:
- matches = portage.db["/"]["vartree"].dbapi.cpv_all()
+ matches = gentoolkit.find_all_installed_packages(lambda x: x.startswith(cat))
But still... why? When is it useful? Clearly it has never been used up
until now.
So I'm still in favor of just dumping it. Seems like complete
superfluous fluff to me. If anyone would have any real-world use for
this, I'll clean it up and keep it in. Otherwise I really don't think
anyone will miss it (especially not Brian :) )
-Doug
P.S. I'm strictly talking about belongs here, category filtering in
all other modules (where it's actually useful and makes sense) is not
only safe but has been upgraded to take multiple categories, so you
can now do:
$ ./equery.py l --category=app-portage,sys-apps port
[ Searching for port in app-portage, sys-apps ... ]
* installed packages
[I--] [ ] app-portage/portage-utils-0.1.29 (0)
[I--] [ ~] sys-apps/portage-2.2_rc23 (0)
^ permalink raw reply [relevance 99%]
Results 1-1 of 1 | reverse | options above
-- pct% links below jump to the message on this page, permalinks otherwise --
2009-02-08 5:07 [gentoo-portage-dev] equery: deprecate --category filtering in belongs Douglas Anderson
2009-02-08 6:30 ` Brian Harring
2009-02-08 7:05 99% ` Douglas Anderson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox