From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 8FA19138350 for ; Wed, 11 Mar 2020 17:12:33 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id A3603E09A1; Wed, 11 Mar 2020 17:12:31 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 6F518E09A1 for ; Wed, 11 Mar 2020 17:12:31 +0000 (UTC) Received: from [IPv6:2604:8540:fcc0:2000::450f] (unknown [IPv6:2604:8540:fcc0:2000::450f]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: zmedico) by smtp.gentoo.org (Postfix) with ESMTPSA id 1A01B34F22D; Wed, 11 Mar 2020 17:12:29 +0000 (UTC) Subject: Re: [gentoo-portage-dev] [PATCH] repoman.modules.vcs.git.changes: reindex (bug 712106) To: gentoo-portage-dev@lists.gentoo.org, Alec Warner References: <20200311071333.20432-1-zmedico@gentoo.org> From: Zac Medico Autocrypt: addr=zmedico@gentoo.org; prefer-encrypt=mutual; keydata= mQINBFs7tmwBEADTzG+IcYtRfTfKryU7sUH7LlV1M+TdaCMfIkY4x6RyHXkaaqYuQ+U9HKn0 +m5FcZsZ1Ojik+We3Tz0F6kDbam6EWzBxmsLb/IHeUEsvsuLzuBQjiD9zzqGocZiPWr+uWJs AdbueS72R7FPXJPDUEPrJ9GdhGFyYARveY9cmdisOwcDOiSFfBjk3/89t4gROn4KUhezVuO9 VS14gVSns1561CJjlB47HkSBu4+FuzrfVygg4xitWAH119Ehw0vJcgkTw4Bqhk01Iw9us80m dFyU8JbJ0CVYe30gYKFFbnXoiT6xLLogKOkv0goPFxaXcMwWM9ei3SjAGVqgN6i8VnO7kquV LwkTe6ntEK0iY+l4qTKuyIOQLpCbWNI0eVwlx5b/pY2pt5TEGWAPMCZGjlidMx0aDcVX4oji 2/xegFAcxALrfOX3kj2FZ9kNAqLZu26AfqtslIqlBEAb5sZwPr351msBIdbaWX2UNw21I478 7eQ7UfohwXQHlXdhc/wop3VDkDzLBnvlK4ozSJI/9T5F/+9yEZvc6DKUWdEfD12o2El5hHan gCUQWDBKqZb1wcekK8KY2tmH8BBQi7k52IWYLJYfJdir/XpGm5SsDpf3zvDcIFXqFHAG7w7b fhriM+6oBOeIO9ew1Xj3swbRhDwdzRUhu7Uqayq1vdvKqGkgcQARAQABtCNaYWNoYXJ5IE1l ZGljbyA8em1lZGljb0BnZW50b28ub3JnPokCVAQTAQgAPgIbAwULCQgHAwUVCgkICwUWAwIB AAIeAQIXgBYhBEdYrNjamv1GpqYECtYQzzch54rNBQJbZpeGBQkEzWcaAAoJENYQzzch54rN iTEQALgfn8NqcY1P3VgE8n/ypYfCa8YhOhZcSlVOnIil9u4F0OPUP9/TFALaW2RRctUm7URP Oe6gMd8mzFauU1q8FKHW8vo6i48Oqb3RmkH4PNbH0EHfM1e3pAq+E6Bi08y7HzYUm5PKr+m3 oLNFvqZuG3RKgmKQTm8E56IpI8rODnVmBkLQEGkdi9hDB1Zkm9dlT+eRGglHAhnpb+AweOzh dvqdfu0SKEoyLjCvRIFltrtNIuKWpjqOVAaMU0hLfDlRVJR0oTThe7P0vhulKZtWS/L7wXJr e7NGIunM09JIAjYAXX5hmY9L0oKnp0WK5PksBKIu8W8TUwzVmTXNAs7qfEQQJ3LvAQo3xifa l2n0ixdoozltU8afxJohz8OKrWOAzE8kqWa+H+t1XZtQAy7yZA3x51vyp4hquyAMYrZbU8hC 0x/l6KM/qGI7RPohw5VxgneQCAbpu/G+3DLVH5QjPR+tKPtpFkEpxrbTNUhaOUqFipX92382 w2CCxDrNrBYbnFYKmVthZqVxrUuDfi4VIgeBkGzDKPwqjSkbdZ0/I5GAmjZh0aJWrRnzCum/ hZHHHcU+wOdXBwwGBhRf9SIaxCfaxw0PB+CZXsswvuaANah2b32EFTPcFCCgFvoGMNSSHFuo JR3PAo6qvwGhYdmTI/Na57P1FF+g3VojnAnK2eIEuQINBFs7tmwBEACfZb/EePObKC8tuVFl IMQaTRzm7q5THbwQvbdKdw/31cdYJaZZ7BFgnSBq2CBYDPxcm+TxvvjgNTam8kZGdEpCm3/v P1YdJSoiYbisJubV7JiAOoAmGtaDOVX5thpv28HL17wqK2d5jgqMTLFeT3hyaro5cjGAQlhT NOyfwVkdFMFLjOhGzq7aki4UZ9ieS/IedoyZvOblf79d5PV1xI0mf2w5yoHcfZRv7nwI9XMz nqlgC9/RQP7O+WfCl2pl9gyd0hc3uqUWl0ke9xHvVxlEdORH/f+OzeybYj9r80GkC6MeqiG8 qzuWO0IZZ5Gvzwkq0KgRAefr9Z/4vmyOiVhJrvk1gLp6VEdB54fUO3MG/PcnYiasRJOUwRQQ 1+q25w5i9ooZRk0LQ6oNnWbeVj+Pwn0mzL0/GjkdPsYclxzOLSlRAwkisepVl62L2m+XwXsZ j9DS3vIHEbbfCmKayBuGCXQEpJMmEnGqFLnOzv29cOutm3BnGXcWAg5aJjiV5PKEmr/4g9/E J8lphGnNCRQ2DvUzO1tlHpmT+JvDBwAgo5rfq5wjjeiS578kAgPoitOBzp/z5YM5FXX+shEd i5/ratErb9ysUfr3Z45YV3yM6MHgCpEg8+5k6fM6ey4tRnxXAYdJ4XzaSyML9fsnEg9aVaCP iRl+fuLSuF1QJf7LwwARAQABiQI8BBgBCAAmAhsMFiEER1is2Nqa/UampgQK1hDPNyHnis0F Al0KotoFCQPRFW4ACgkQ1hDPNyHnis1CCg//ZOK07qtPUdRqMgD83BrXfzF+eLvzfkCuMqdO TWexli5pCwVrYLdystEbH60I1+ocBEbjMKqGoGt4HbEW3wq6zmHdKr5AIK4M3bGdlEI3cuPY QDdU8gFlwGpm79QnPAqXMiXeO2hlm2hYAhQ7Ir+q/lc3jxDQisuGtoIZZQ43MwPX95gy1kPz uGUmrT9Jl5m9ujHnLrQpCgUKLkRibGijx/A2p5MmtONMlKjtNXsSaRofabcfKD/RB0RCSft+ fYYgQ8PiYikpWi3+Z6PTH8Ivb7j7Hk0ZrB2toN51YE1wOKUN3i53K9fdTtI72lzvVrR15eRZ vahOB0tHAS8e2ZYQOXccqVcvc9YO8ZP5lfn/x2Vo+EgKK55FlIZrowI3deZYZDN6lz9rvhid 257TZrmUeJFdVA/MqK3ICBO0KkwAsMsl07ILOXq7rZBeDDNWTq/uIzl3fDRRhq+njdUejkqS F//EmOh8+iKhmdE0CJkzzYgHC4W+CDLo4gM3TznXi827zVAdsnk9ldmyBfHq/kkpfuGpx9L8 BeCLbkv/7I3sbT4POdsYeYC2ULhqCtGsY2Vtzf3ygb+BsUxAEG3IM62GcMydBzL12gkk73WQ XxuUVSEUB4CchrAprWtYYZ1OIKNnh7tT5IrBjhNujBjAyRYz+1CHTiM3MoXH68TkIaBB+065 Ag0EWzvRagEQANK1C/HvZgnFVa+3tFmS4OVnCRO611C7WXubm5Y2xj/Lh2LOWv5TeTtTp5FR S3961b429TbJNv0q9N4mDi6XOGpZvWLkfiDw/VT9I+48B2eVXKx5N2H48S7t1Knwut6vuTEx 14MGiZToCs2Tu1fEUnaBv2Hg60ysVfplDAQadixzboLHM1DxLYn1W/cAUrhXAW5uNQlyE0Ze kiB10JxbnAurdpRSu4X81IrGJDK/oNAgAcWRieVX5J1N5LStPrloFKf+Dtl2z49WibXVTjwF Ir/BZYprkTTgNzeM3VRPnyRz7IA1pMkVX0r4C0O38mqHyDCpkM/TKsOpNMDqYcllD8Fa/Zyg S08RLymWvRXWn7Sz7MlZE9CCQ2aG+N20esYH3nwrYsdUdj87/nSwqYKhTWwBBIWtrrCHw56O ZMTXznX3OkLOBB0gXH92G5dKv4azBeAZzR6c+qvP6PxgVuAlvlnFbzgW5m4CrkTsEwSh/s2Y d9sJPctzkPkif6tDWk0qKy9lRwTKyOK0xqwZGcJBLdqInU05DLJlrf2QJKBS2SE1tEparQvT 8/+EBpzGk0omSxGmDxLW6EY1CTXV+LfbRYz42Y71f7aVNNqfF/CbJYLupe9DadjvceRM/ZFG WO6SzWoO7ed5uT2i8M33tC2EnK/BL1oZ5Wr7Kv5XED10JI+5ABEBAAGJBNIEGAEIACYCGwIW IQRHWKzY2pr9RqamBArWEM83IeeKzQUCXQqi2wUJA9D6cAKgwdQgBBkBCAB9FiEE8OgXaltW zqgSupCu0HX7jBBKPSAFAls70WpfFIAAAAAALgAoaXNzdWVyLWZwckBub3RhdGlvbnMub3Bl bnBncC5maWZ0aGhvcnNlbWFuLm5ldEYwRTgxNzZBNUI1NkNFQTgxMkJBOTBBRUQwNzVGQjhD MTA0QTNEMjAACgkQ0HX7jBBKPSAkQw/+I/z0S3uMfcCL3DVtDX1PQKE4Pg7foiOKxJMZNiyh 4gBSCRr9cWa5BICB5OPlNzvf83LRXmOxyOa1UqFRsWQsZ60e4DSAcmnER6ePTN50AhDfpOhT SCJrtCyTtykkklGB7d91pSBvhpRxTl9ODaWQ92wypbYHX92OUrPpPZypfzKia8HKIF1FJZUm VGaCphBMnJBrrMsRFZyScIb1PagP3L1UmVVbeRwtPZCYHpr/er8zSAJQGXyoYdlgMa/7Sy7h J6mlDkEA6709c1XykZ2pMyyKtD4TbQrlCmvOY+DmRUbjHyobVSlGkL+En0TvnBrH2jhauocf g2aG+cv89+zaMrs8kuL/FGq87rnAYY77glbSRqKWGO8uhFgmLQHqKvkmG0rjiRy1yquftDKA 71kHmvb+LUvJmsD4tYotyl3vHGutq6cWJ2hzrczPlBp29YZw524zoM4pLhuwuCvnZX7jXdSR 228Gu7/iED2zULwOlzoNPSnTAVInsQEoTh2W71UKcn37tfodUyirtoyPtlaonVLUmn+bq4nD MEN7FxOiSPytM8HNsij7cR9oZYyTjtWhCBxx57kHWO/GYvGEhsR34tRz16SMNDQURM3t04G4 giDn5noh0DJywswd815JM/SMwcdkEpum1DCJpD+GJ4xtKto3p+OjO1riPDyZQGg4lOAJENYQ zzch54rNIqAP/2SA8lGZYHz5XzWrFkszK0T/xScQPbaPa23WQ6Xdw3JyVCcRfWqlZtEtP0K3 w2AA33jFJ1JRio7le+WSS+YMAlW6q6vlcKrQoe1eeQoN8NsILCyp5fXfKeASHzbWt1ClWZm4 Q+rU5L3cL+BTmg+C83ywnhrw/839zejduDDwLQiEm4x3xQ0tpy65TgYOl1AhVJBlmgDRavjE oVGiaQIpxrHANrAJMMS9RpXhHQk4g9JetZFjupvzKzvbNxfm1NmFNCH92IQCd1Az415Hg8yw iVVLlCb92u4AeO2WQMMmQLwk0UQfpM6f3NMCbhW/y5P7Ie2zxm96LktNRVY6IO7PbWRE8ih9 uTyzd4T7V+3sDEB4OfJ1btMcfFbeEx4aJ6xGM7AykEns3I8oj5jufBuupz6Z5cvR4OV+Qz1B DsOVrLRS4saTCEXdoi2D1LL8dwBHvLP5tuHP9bDYXvIM/8v7c4wOq8WZvBGbOz3oEYFwuUS/ Hs6hli8QgovhO8KS3zyBo7q0dNzwQZ/G8/vKrmZS02/Yvv8yaqhH75pOfuZe6QQSIzn6M7gy Dcw47b5d/SDAgXU/ztlXUys+4lLoz6gBCTheaQF3OEBF2LlyTWHVPeY7nKe/B1k6ZPnL2SgU 1si1MD81KA9EcfcjOZQHgkHkzNRKN28CgTxp1cc1hWvZaGCC Message-ID: <79ea4eef-9543-f3d0-89f0-0785cb4d5a88@gentoo.org> Date: Wed, 11 Mar 2020 10:12:26 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-portage-dev@lists.gentoo.org Reply-to: gentoo-portage-dev@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="5LjEwrt4o5nQEyyHbG93wFPi4oX7U84b1" X-Archives-Salt: ac95a6d3-4235-4bb1-a1b7-0b520b1d45f1 X-Archives-Hash: 594af5b298a54695ba0b4d9a9c965fc4 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --5LjEwrt4o5nQEyyHbG93wFPi4oX7U84b1 Content-Type: multipart/mixed; boundary="OOC8HIbk6SDE5dTfTW2au6vvvuCKAe0rI" --OOC8HIbk6SDE5dTfTW2au6vvvuCKAe0rI Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 3/11/20 9:37 AM, Alec Warner wrote: > On Wed, Mar 11, 2020 at 12:16 AM Zac Medico > wrote: >=20 > For files returned by git diff-index, call git update-index in orde= r > to ensure that the index reflects the state on disk. This will prev= ent > incorrect assumptions in cases where the index is missing or stale = for > some reason. Since repoman uses this information to decide when to > update copyright header dates, this can prevent spurious copyright > header updates. >=20 > Signed-off-by: Zac Medico > > Bug: https://bugs.gentoo.org/712106 > --- > =C2=A0repoman/lib/repoman/modules/vcs/git/changes.py | 15 +++++++++= +++--- > =C2=A01 file changed, 12 insertions(+), 3 deletions(-) >=20 > diff --git a/repoman/lib/repoman/modules/vcs/git/changes.py > b/repoman/lib/repoman/modules/vcs/git/changes.py > index 7e9ac1eb5..ebf770d53 100644 > --- a/repoman/lib/repoman/modules/vcs/git/changes.py > +++ b/repoman/lib/repoman/modules/vcs/git/changes.py > @@ -29,8 +29,14 @@ class Changes(ChangesBase): > =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 ''' > =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 super(Chang= es, self).__init__(options, repo_settings) >=20 > -=C2=A0 =C2=A0 =C2=A0 =C2=A0def _scan(self): > -=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0'''VCS type= scan function, looks for all detectable > changes''' > +=C2=A0 =C2=A0 =C2=A0 =C2=A0def _scan(self, _reindex=3DTrue): >=20 >=20 > Why the underscore prefix? >=20 > -A I can't think of a reason to use this parameter aside from this recursive call, and the underscore hints at this. --=20 Thanks, Zac --OOC8HIbk6SDE5dTfTW2au6vvvuCKAe0rI-- --5LjEwrt4o5nQEyyHbG93wFPi4oX7U84b1 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQKTBAEBCgB9FiEE8OgXaltWzqgSupCu0HX7jBBKPSAFAl5pG/pfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldEYw RTgxNzZBNUI1NkNFQTgxMkJBOTBBRUQwNzVGQjhDMTA0QTNEMjAACgkQ0HX7jBBK PSDM+w/+O1hIsTyQMGLzjVV3p/JNf/qeqjdzta8BUsd2loThdaclA4E0K5LH+Mnj 0hoBz4A9ugYRo9LmPLH2JTT6kUvI3vSvhvc2ywT1BmEewVLCh1I5OPXbA/gVtZ4T cndiqOAX9PinnRhBTG/oUiatwyKT5xsIJfxIJ44mmjYUstliaX+pcujdyu/n34Xr 2w+9yAYKGnKboNfI4cg9wTiH1jIc6agRtBDFODpCe4wyO1W0dqdzxKxVWMu1sjSF Mm3Zn3B/6kJQKnKpb4KiMOA9wmHKSQlBJdZVIkTHNLK3IbyrQ/owrHtssTuLRYUj vWAFKZz/qCy28QlPr0lfEwu9RG8FIrSv41Geg2V7j2nmqXfEq0AK8D/wB7xYCYnw 9dpIO4/J978TP3vtemXtobIBMGp6rMbNuxN7CGJr0iPJN9UcZfMPaPerH7b20cJw EuRML5b/7sSJjmEnhyhBsZpGhjcbRAMqEsjXTXAJTpxd7J9rYBV/6fh8QUQZJozj mC/dx2MeRhw6iPbyqeWa/N/3y95/ftuHO1Y+dD1/PR9Z4aHppVeYFRXIaEBtN9HB x6+zgBh7FoLCMos9Mk+qdN+7uI/huCsVZ7zmStsVuMD9s/3iGS3rneFLUA/fTM6g jPmfNKK9lwrvZ7hGLO5Oh2QZ6Aa1+v04KohaSHPJOoqw+UDs3mI= =nGwq -----END PGP SIGNATURE----- --5LjEwrt4o5nQEyyHbG93wFPi4oX7U84b1--