From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 304F41381F1 for ; Mon, 19 Mar 2018 22:59:19 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id D6D63E0A5B; Mon, 19 Mar 2018 22:59:17 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 87901E09DD for ; Mon, 19 Mar 2018 22:59:16 +0000 (UTC) Received: from [10.128.13.172] (unknown [100.42.98.196]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: zmedico) by smtp.gentoo.org (Postfix) with ESMTPSA id 173EA335C0C; Mon, 19 Mar 2018 22:59:15 +0000 (UTC) Subject: Re: [gentoo-portage-dev] [PATCH 0/3] INSTALL_MASK refurbishing resubmit To: gentoo-portage-dev@lists.gentoo.org, =?UTF-8?B?TWljaGHFgiBHw7Nybnk=?= References: <20180315192212.13454-1-mgorny@gentoo.org> From: Zac Medico Message-ID: <69cb373e-9260-9f06-058d-ed269509484b@gentoo.org> Date: Mon, 19 Mar 2018 15:59:12 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-portage-dev@lists.gentoo.org Reply-to: gentoo-portage-dev@lists.gentoo.org MIME-Version: 1.0 In-Reply-To: <20180315192212.13454-1-mgorny@gentoo.org> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="H4MkQdiwh552xJTJat007UDiazeU7p45Z" X-Archives-Salt: 09060e9b-f944-4b49-b6a4-51d74326150e X-Archives-Hash: 6a5f1eed657ca4337b4470f69cca8105 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --H4MkQdiwh552xJTJat007UDiazeU7p45Z Content-Type: multipart/mixed; boundary="RXkmm1VQBmjoVdCTIQej3gnPb0AyVp5Bn"; protected-headers="v1" From: Zac Medico To: gentoo-portage-dev@lists.gentoo.org, =?UTF-8?B?TWljaGHFgiBHw7Nybnk=?= Message-ID: <69cb373e-9260-9f06-058d-ed269509484b@gentoo.org> Subject: Re: [gentoo-portage-dev] [PATCH 0/3] INSTALL_MASK refurbishing resubmit References: <20180315192212.13454-1-mgorny@gentoo.org> In-Reply-To: <20180315192212.13454-1-mgorny@gentoo.org> --RXkmm1VQBmjoVdCTIQej3gnPb0AyVp5Bn Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 03/15/2018 12:22 PM, Micha=C5=82 G=C3=B3rny wrote: > Hi, >=20 > Here are three of four INSTALL_MASK updates I've sent long time ago > which were not really reviewed. The fourth patch added support > for repo-defined install-mask.conf and I'll do that separately. >=20 > Those patches focus on smaller changes. What they change, in order: >=20 > 1. Removes explicit file removal code for FEATURES=3Dno*. Instead, thos= e > values are converted into additional INSTALL_MASK entries > and handled directly via INSTALL_MASK processing. >=20 > 2. Rework INSTALL_MASK to filter files while installing instead of > pre-stripping them. In other words, before: INSTALL_MASK removes > files from ${D} before merge. After: ${D} contains all the files, > Portage just skip INSTALL_MASK-ed stuff, verbosely indicating that. >=20 > 3. Adds support for exclusions in INSTALL_MASK. In other words, you > can do stuff like: >=20 > INSTALL_MASK=3D"/usr/share/locale -/usr/share/locale/en_US" >=20 > I have been using this via user patches since the last submission. > Guessing by 'git log', this means almost 2 years now. >=20 > -- > Best regards, > Micha=C5=82 G=C3=B3rny >=20 > Micha=C5=82 G=C3=B3rny (3): > portage.package.ebuild.config: Move FEATURES=3Dno* handling there > portage.dbapi.vartree: Move INSTALL_MASK handling into merging > portage.dbapi.vartree: Support exclusions in INSTALL_MASK >=20 > bin/misc-functions.sh | 30 ---------- > pym/portage/dbapi/vartree.py | 104 ++++++++++++++++++++++-----= -------- > pym/portage/package/ebuild/config.py | 11 ++++ > 3 files changed, 77 insertions(+), 68 deletions(-) >=20 As mentioned in #gentoo-portage today, the rationale for including the INSTALL_MASKed files in CONTENTS is to that we can detect collisions that would have occurred had people not been using INSTALL_MASK. Since people can use INSTALL_MASK to intentionally prevent collisions, in cases where COLLISION_IGNORE is not appropriate (this is common practice at my workplace), we'll need a new FEATURES setting to trigger the new behavior where INSTALL_MASKed files still trigger file collisions= =2E --=20 Thanks, Zac --RXkmm1VQBmjoVdCTIQej3gnPb0AyVp5Bn-- --H4MkQdiwh552xJTJat007UDiazeU7p45Z Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iHEEARECADEWIQSG5RNTeMgVEruefzL96O+FrlcZowUCWrBAwRMcem1lZGljb0Bn ZW50b28ub3JnAAoJEP3o74WuVxmjONUAoODMHLFTzJf+sIkG9z/d1TbijilzAKCC c2tSf9VhYMt2WvlNnLgMhx4R0w== =hWcq -----END PGP SIGNATURE----- --H4MkQdiwh552xJTJat007UDiazeU7p45Z--