From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id 7B0B6138CA2 for ; Wed, 22 Apr 2015 23:44:27 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 97970E0815; Wed, 22 Apr 2015 23:44:24 +0000 (UTC) Received: from toothrot.meleeweb.net (fr1.as29.net [62.210.131.231]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 0BC36E07C5 for ; Wed, 22 Apr 2015 23:44:23 +0000 (UTC) Received: from localhost ([::1]:40687 helo=mail.meleeweb.net) by toothrot.meleeweb.net with esmtp id 1Yl4JZ-0006qE-P2; Thu, 23 Apr 2015 01:44:21 +0200 Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-portage-dev@lists.gentoo.org Reply-to: gentoo-portage-dev@lists.gentoo.org MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Thu, 23 Apr 2015 00:44:21 +0100 From: Bertrand Jacquin To: gentoo-portage-dev@lists.gentoo.org Cc: Zac Medico Subject: Re: [gentoo-portage-dev] [PATCHv3 1/2] MEDIUM: misc-functions: Be more quiet when removing non existing =?UTF-8?Q?INSTALL=5FMASK?= In-Reply-To: <55359BBB.4080605@gentoo.org> References: <1429559160-11646-1-git-send-email-bertrand@jacquin.bzh> <55358E1D.1070801@gentoo.org> <55359BBB.4080605@gentoo.org> Message-ID: <5cac28faa26324f08cc2bba6a17583e3@mail.meleeweb.net> X-Sender: bertrand@jacquin.bzh User-Agent: Roundcube Webmail X-Archives-Salt: 09df7f70-3b18-4712-9e6d-ed763cc8901c X-Archives-Hash: 846b660e7431555c5ed33e30a2be8d56 On 21/04/2015 01:37, Zac Medico wrote: > On 04/20/2015 05:31 PM, Bertrand Jacquin wrote: >> On 21/04/2015 00:39, Zac Medico wrote: >>> These are in the master branch now: >>> >>> https://gitweb.gentoo.org/proj/portage.git/commit/?id=5a1b870fe54ac06f864a648c3ea5cc118f6ce911 >>> >>> https://gitweb.gentoo.org/proj/portage.git/commit/?id=e74e2670e3f043608fced9847e54bdbb19f35169 >>> >> >> Thanks for that :) >> >>> I modified the test as follows in order to ensure that it still works >>> with shell globs: >>> >>> if [[ -e "${root}"/${no_inst} || "${root}"/${no_inst} != $(echo >>> "${root}"/${no_inst}) ]] ; then >> >> I do not really understand the use case here, do you have an example ? >> >> Cheers, >> > > Well, I don't use INSTALL_MASK myself, so I don't have a real-world > use-case for you. However, it's clear that the code will expand shell > globs, so I preserved that behavior for compatibility. Sorry Zac, I was speaking about the $(echo ..), what does it bring to use it here ? Cheers, -- Bertrand