From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 0CEB41382FE for ; Tue, 12 Jul 2016 14:00:16 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id E26A6E0A40; Tue, 12 Jul 2016 14:00:09 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 5BE18E09C5 for ; Tue, 12 Jul 2016 14:00:09 +0000 (UTC) Received: from [109.189.223.149] (149.223.189.109.customer.cdi.no [109.189.223.149]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: bernalex) by smtp.gentoo.org (Postfix) with ESMTPSA id D88F2340C9F for ; Tue, 12 Jul 2016 14:00:02 +0000 (UTC) Subject: Re: [gentoo-portage-dev] [PATCH v3] portage.cache: write md5 instead of mtime (bug 568934) To: gentoo-portage-dev@lists.gentoo.org References: <1468133471-18377-1-git-send-email-zmedico@gentoo.org> <1468181882-24038-1-git-send-email-zmedico@gentoo.org> From: Alexander Berntsen Message-ID: <5784F7C4.5080700@gentoo.org> Date: Tue, 12 Jul 2016 15:59:32 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-portage-dev@lists.gentoo.org Reply-to: gentoo-portage-dev@lists.gentoo.org MIME-Version: 1.0 In-Reply-To: <1468181882-24038-1-git-send-email-zmedico@gentoo.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Archives-Salt: 0520e753-c808-4792-a367-550ee2fea1f6 X-Archives-Hash: e738094f4ea02ea5b8fd26e4ae49b60a -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512 The _chf_deserializers and _md5_deserializer stuff looks rather overengineered. I don't know what the reconstruct_eclasses skipping entails (the comment makes it seem like "skip this because apparently it's different lol who knows -_o_-"). The rest of the patch lgtm. - -- Alexander bernalex@gentoo.org https://secure.plaimi.net/~alexander -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCgAGBQJXhPfCAAoJENQqWdRUGk8BGD8QAN6DgO0LDe6L8+yFzljTS79k ctrEvV+cm6Ti8crBuXzjgEi2hmSWwEbpFi/OjAA+8JuDVigqSOF1qh32UyhgAK2m ugm9Vs6/ooQ6NqJu1xd5NF342ul06DNvsU9kKQsmoO8f03EmHRKlAxCFIs5UBl1P 0cd5ULg/dFANzpe2zKFDVk0YGgFmrN8X2nziosttb0MrgfMkAP712ZcEAtHMusWj iKz0ByJcogTvuWJLKSoMQbU1EGm+/NjRB7mV3BN7LBoVarPmCt//s6jG7GkFTiNI T6sDsn/rFOdFyiGmxXaZ+3ztv3z7WFHvHGzyyCqofJceYxjmaT1vk0itWYDACi7O QJmsZ+EnL72z3i+J3AwONtqixBQkJ/Jpt7Ye/O2drRA8eHZ2wJODH2jnFONKvf75 v2JfnWy1X63SikNorsn9/WE4j00rky/0fA+0WR2anMW01B8cgZU/LhaoNzIsV696 3XNmwNjZDmhhngUfj/vEVgtpopOiG2m96Myq2opw1wXv8pI6OmQevaOCuLpOMmpm yaRCcYNWRJ5QY0FQJJoIIqwMdiuXov+uQhRIQ6Im0THEOYKmwCwETFAPfXMETYn7 qTgj51RiK1NHl5mibojjcJJHTWHLg++XSEfuUJnlBL8GdApIUtC1dE4+BmYcVlxt i3ojLlHlG8Gc/+TkaR8f =lxGo -----END PGP SIGNATURE-----