From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id 33BD41382C5 for ; Thu, 23 Jun 2016 08:03:31 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 375ABE0A7C; Thu, 23 Jun 2016 08:03:29 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id AF323E0A76 for ; Thu, 23 Jun 2016 08:03:28 +0000 (UTC) Received: from [192.168.0.20] (ip68-5-185-102.oc.oc.cox.net [68.5.185.102]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: zmedico) by smtp.gentoo.org (Postfix) with ESMTPSA id 2785F340B25 for ; Thu, 23 Jun 2016 08:03:12 +0000 (UTC) Subject: [gentoo-portage-dev] Re: [PATCH 2/2] depgraph: fix missed llvm update (bug 584626) To: gentoo-portage-dev@lists.gentoo.org References: <1466667534-12985-1-git-send-email-zmedico@gentoo.org> <1466667534-12985-2-git-send-email-zmedico@gentoo.org> From: Zac Medico Message-ID: <576B97BF.7030600@gentoo.org> Date: Thu, 23 Jun 2016 01:03:11 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-portage-dev@lists.gentoo.org Reply-to: gentoo-portage-dev@lists.gentoo.org MIME-Version: 1.0 In-Reply-To: <1466667534-12985-2-git-send-email-zmedico@gentoo.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Archives-Salt: 850e1cc4-7112-4dbe-b21d-752da86c2dab X-Archives-Hash: 7dc9f30458710c7691fd29b7f380c3e0 On 06/23/2016 12:38 AM, Zac Medico wrote: > @@ -2113,6 +2129,19 @@ class depgraph(object): > > self._dynamic_config._need_restart = True > > + def _upgrade_available(self, pkg): > + """ > + Detect cases where an upgrade of the given package is available > + within the same slot. > + """ > + available_pkg = None > + for available_pkg in self._iter_similar_available(pkg, > + pkg.slot_atom): > + if available_pkg >= pkg: > + return True > + > + return False > + I've fixed this method to use the > operator instead of the >= operator. The latest version is in my branch here: https://github.com/zmedico/portage/tree/bug_584626 I've also opened this pull request so that travis runs the tests: https://github.com/gentoo/portage/pull/29 -- Thanks, Zac