[gentoo-portage-dev] [PATCH v2] repoman: declare '-x', '--xmlparse' command line options obsolete

[gentoo-portage-dev] [PATCH v2] repoman: declare '-x', '--xmlparse' command line options obsolete

[Göktürk Yüksek]

Repoman pulls in lxml unconditionally now and performs metadata checks
by default. This behavior makes these command line options obsolete
since forcing the default makes little sense. Declare them obsolete
instead of removing them for backwards compatibility.
---
 repoman/man/repoman.1            | 2 +-
 repoman/pym/repoman/argparser.py | 4 +++-
 2 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/repoman/man/repoman.1 b/repoman/man/repoman.1
index e2b9c66..88b3e5e 100644
--- a/repoman/man/repoman.1
+++ b/repoman/man/repoman.1
@@ -60,7 +60,7 @@ Be less verbose about extraneous info
 Don't commit or fix anything; just show what would be done
 .TP
 \fB-x\fR, \fB--xmlparse\fR
-Forces the metadata.xml parse check to be carried out
+(OBSOLETE, always enabled) Forces the metadata.xml parse check to be carried out
 .TP
 \fB-v\fR, \fB--verbose\fR
 Displays every package name while checking
diff --git a/repoman/pym/repoman/argparser.py b/repoman/pym/repoman/argparser.py
index 2d56a87..32758aa 100644
--- a/repoman/pym/repoman/argparser.py
+++ b/repoman/pym/repoman/argparser.py
@@ -117,7 +117,9 @@ def parse_args(argv, qahelp, repoman_default_opts):
 	parser.add_argument(
 		'-x', '--xmlparse', dest='xml_parse', action='store_true',
 		default=False,
-		help='forces the metadata.xml parse check to be carried out')
+		help=(
+			'(OBSOLETE, always enabled) '
+			'forces the metadata.xml parse check to be carried out'))
 
 	parser.add_argument(
 		'--if-modified', choices=('y', 'n'), default='n',
-- 
2.7.3

Re: [gentoo-portage-dev] [PATCH v2] repoman: declare '-x', '--xmlparse' command line options obsolete

[Alexander Berntsen]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

When submitting v2-patches, please submit them in-reply-to=the message
ID of the original thread.

The patch looks OK, but I don't recall us using the "OBSOLETE" phrase
in any documentation. Does anybody know any phrase we should be using
instead, and why we should be using that phrase instead?

Maybe we should pick a term ("OBSOLETE" is fine by me), and make it
"official" for these situations in the future.
- -- 
Alexander
bernalex@gentoo.org
https://secure.plaimi.net/~alexander
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQIcBAEBCgAGBQJXQuHFAAoJENQqWdRUGk8B74sP/3gMywA7AWshVzsyzEA2PRf2
LNaW0vb98zSq5DbRuqN5624i83g20wk2GHNm/8ZqS1yuTrjNmJ3XjXJriQwCIryL
cJTvz0FxrOdGcmT7/SWTI3vT0P6yOA5s+rrNp8jBPqeDQFAcy8eZbTDa8A9KtWmZ
w6ZQ+ht3mQqLt3VkADDbzqX5/w1szi8isQXkFFKUn4en54A9KQsmsFWRqKYNpUPK
7HXSTHhvPtSyoYxjBxKVd+chbDHVFbIqVWuuJfoSro3RiKDnCjzxYjuqcP8mRxfp
s9O0LCynAwWBrTQwBJd0FRPp5Y95vRENCP+18XnT4cI3S+2TdJAptW+MfZrAXKz/
9OKJfuwkdvpOqdNtpk0mmbe19CIiCEFiZXP+wC+8JtyuEE+gwfUJaPbz5MFNLqRo
TLPHvjphrtmyvasa8ZxocB7mF9uCwZSaPbxf0jr80axvBcVZPREY/a15SbOJliZI
mBzqxto1mX6idWONMLIhWwwwV0SMEkOTxl4Osh/De2FbnSW47rOQxJdXs0jXQXW/
KOlVX7h7PzQ7KqS9lDpHJsyRMseRPMq3BTfwW+pMs3qwKEDg2Ge4p1E8aGv7Bjj8
LoPvPuGV2Vy51ZzowMqHxQzYTXdnHq33TDI8M/1qaJaIdrhSsGbmcoJt2YQuXPkE
d+6/eMbY0YERDJ6FTofe
=eAJu
-----END PGP SIGNATURE-----

[gentoo-portage-dev] Re: [PATCH v2] repoman: declare '-x', '--xmlparse' command line options obsolete

[Duncan]

Alexander Berntsen posted on Mon, 23 May 2016 12:56:06 +0200 as excerpted:

> When submitting v2-patches, please submit them in-reply-to=the message
> ID of the original thread.

It isn't mandatory here and many ignore it, but many readers (like me) 
and more importantly reviewers find a short, often one-line description 
of what changed between versions useful as well.  A multi-revision patch 
will thus have a mini-changelog of what happened at each revision.  While 
not mandatory here, it is considered so on many lists including most linux 
kernel related lists.

> The patch looks OK, but I don't recall us using the "OBSOLETE" phrase in
> any documentation. Does anybody know any phrase we should be using
> instead, and why we should be using that phrase instead?
> 
> Maybe we should pick a term ("OBSOLETE" is fine by me), and make it
> "official" for these situations in the future.

No argument with obsolete here, but as long as the option is still 
allowed (even if ignored) for backward compatibility, isn't "deprecated" 
the usual term?

Then "obsolete" can be reserved for continued listing (for historical 
reasons...) after the option is no longer allowed (whether it directly 
triggers an error or simply isn't processed at all, thus likely 
triggering an indirect error due to incorrect parsing of other options 
and parameters on the command line).

-- 
Duncan - List replies preferred.   No HTML msgs.
"Every nonfree program has a lord, a master --
and if you use the program, he is your master."  Richard Stallman

Re: [gentoo-portage-dev] Re: [PATCH v2] repoman: declare '-x', '--xmlparse' command line options obsolete

[Alexander Berntsen]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

On 24/05/16 02:31, Duncan wrote:
> No argument with obsolete here, but as long as the option is still
>  allowed (even if ignored) for backward compatibility, isn't
> "deprecated" the usual term?
I meant to ask if there is any existing precedent in Portage.
"Deprecated" would be my pick as well.

- -- 
Alexander
bernalex@gentoo.org
https://secure.plaimi.net/~alexander
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQIcBAEBCgAGBQJXRBg6AAoJENQqWdRUGk8BzV0QALaoe2bLRVSy1xEzQlj83XvD
48cUerVji6qM1C4+e+fWPrEZ4JOwsXLjYyCOl3K3Oop3vuDaMtaA42eDcZcjczJ5
UeWp3cghzoSigGipFif5IjTNvlgW13vK5FcQ7mED+hWZM8kYfoW8pDv52AzMSAhq
VBVF4NuNSkmfBqRl6l1+oVdsV+qBhlhf2JYHVGGb0Fop3VKYFmDDJ537bKUEOJ6+
K9qXZzIqTwqiNTp0rFOjNgJp9qfSLEdspsSNqI7mT+IL302is11PtTS7EtikpIsX
ZPYAZYBPf7OzQLvdJozMLeU6nLW8V8gNYizksXj8LHfFdFAQEifvz+jSHA4bf0rQ
WyifKCd/c2aVPSSzSE5l9wqrS/uA4S4PKINJGWALQhMrD6NzHa837MdUBnvEzJTP
+6Ykq/M+qZmWS2TwIk4z97l4CFiU7QtjityLVJGWDGCNia3ikzFtgWwTmp2jBZaj
O3gCulZYfIADKpGlGMXA4i09ZZOp0mf2iczrrXeJdvl8i6Q2sfUV/c1VD8rO/Pfa
ZC+nlV2lIDePncfzsaHPRvDSoRThR3Hyk/ApBN/PJJojo3+uLnH4p1VQSb1cTQdi
b11p9JlfVz1mCtBnHcH6r5ghL3KwyWjVrHf0dUt69aG6x4klt1TG4LNo9QU/wbX9
J5iMIYMwmyjp+X6Ge6AZ
=pynC
-----END PGP SIGNATURE-----