From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id 5CF7D138262 for ; Sun, 22 May 2016 18:04:57 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 45C3D234005; Sun, 22 May 2016 18:04:55 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id ACAB8234004 for ; Sun, 22 May 2016 18:04:54 +0000 (UTC) Received: from [192.168.0.20] (ip68-5-185-102.oc.oc.cox.net [68.5.185.102]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: zmedico) by smtp.gentoo.org (Postfix) with ESMTPSA id 81470340906; Sun, 22 May 2016 18:04:53 +0000 (UTC) Subject: Re: [gentoo-portage-dev] [PATCH 2/2] portage.util.configparser: Commonize portable config file reading routine To: gentoo-portage-dev@lists.gentoo.org References: <20160522084148.2658-1-mgorny@gentoo.org> <20160522084148.2658-2-mgorny@gentoo.org> Cc: =?UTF-8?B?TWljaGHFgiBHw7Nybnk=?= From: Zac Medico Message-ID: <5741F4C3.5080803@gentoo.org> Date: Sun, 22 May 2016 11:04:51 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-portage-dev@lists.gentoo.org Reply-to: gentoo-portage-dev@lists.gentoo.org MIME-Version: 1.0 In-Reply-To: <20160522084148.2658-2-mgorny@gentoo.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Archives-Salt: 710dccf5-46c1-4529-862c-2884a6d81a9a X-Archives-Hash: b782a3543ec6b5d1fd73392080121c95 On 05/22/2016 01:41 AM, Michał Górny wrote: > --- > pym/portage/_sets/__init__.py | 29 ++----------------- > pym/portage/repository/config.py | 38 ++----------------------- > pym/portage/util/_desktop_entry.py | 20 ++----------- > pym/portage/util/configparser.py | 57 +++++++++++++++++++++++++++++++++++++- > 4 files changed, 64 insertions(+), 80 deletions(-) These patches look good. Note that the _native_kwargs function is not really needed anymore, because it was just a workaround for this issue which only affected python 2.6.4 and earlier: http://bugs.python.org/issue4978 -- Thanks, Zac