From: Alexander Berntsen <bernalex@gentoo.org>
To: gentoo-portage-dev@lists.gentoo.org
Subject: Re: [gentoo-portage-dev] [PATCH] emerge: add --search-fuzzy and --search-fuzzy-cutoff options (bug 65566)
Date: Fri, 8 Apr 2016 13:33:01 +0200 [thread overview]
Message-ID: <570796ED.8040608@gentoo.org> (raw)
In-Reply-To: <57074E05.4030202@gentoo.org>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
On 08/04/16 08:21, Zac Medico wrote:
> Reverse? You want it to measure dissimilarity? Not sure what you
> mean.
Sorry, I meant reverse the *docs* to mean "find things that are at
least 50% similar" rather than "cut off things that aren't above the
0.5 threshold". I.e. use an inclusive sentence. I feel that this is
more clear.
> I just want it to fail if the input is invalid.
Yes, I just realised you checked if it were <=, not just <. I think
this is a bad idea. It's easily missed -- I just missed it last time
around. I would suggest to make it fail early, rather than set it to
0.0 which you then set to None. Just set it to None immediately.
- --
Alexander
bernalex@gentoo.org
https://secure.plaimi.net/~alexander
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2
iQIcBAEBCgAGBQJXB5bsAAoJENQqWdRUGk8BSO8QAKXJlxYpetrA8kKbvW/cknoO
wrLPkHsmn7imnfQddcXVHtE+K1GJCRcG1Eu2VD+Pqza3HLRPl20eTm8+iu+maftk
K41+SCNEb8qs9v05P2wcqPxtUlzI4OO9GwJFJkbycRxgCFtCYnM/0B2kXaSKOkHr
KY4cF9CbdzfwIYL2FkmaCJrCBI9ac1sjsnug9yN+wXIYVV6nzpPLPq8QJU9P6sef
XI7na2mMHpK75FHl5fW/yVJfCXuBHmGgryfyEm+uUtvpLWpGceRBbRl4naJljbsf
AVNSocBmPdWGL6PCdfcD5MID8iriIBfTYWLsAoBN1HcKKasSKr1BG+UxT3wGov7n
STbQ7MLVQpDluS3kCgjbVNWUlouOcVhcNdOniC3GEDxzpT9ev7Tk/FilMNNu167N
l28SaGUokLQnf/EuQfQmNJJyHpFIVsxeRs5ODQZDlvb10WHDFMtYCkXZDhrLJmm6
Ej+tFJiuMWfAIejzVkJ0gvZTvg5FzVknvEey9iNokzXnOsngIjaR4gS8KjUUH0k8
EF1348cJ3KwQxbkWifsEuVosDmiSFaF38j73IoYaHOQh06bVPm2gL/zGeGntDGQY
X+RXL5XTJefiKps1jG4e96jYEUWIIlA/fodxkERKXcEmOsvT29v5gEAwcq6YGWXG
McLGDbOpF/n9tuxihQQK
=GgNP
-----END PGP SIGNATURE-----
next prev parent reply other threads:[~2016-04-08 11:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-04 5:03 [gentoo-portage-dev] [PATCH] emerge: add --search-fuzzy and --search-fuzzy-cutoff options (bug 65566) Zac Medico
2016-04-04 8:39 ` Alexander Berntsen
2016-04-08 6:21 ` Zac Medico
2016-04-08 11:33 ` Alexander Berntsen [this message]
2016-07-25 2:58 ` Zac Medico
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=570796ED.8040608@gentoo.org \
--to=bernalex@gentoo.org \
--cc=gentoo-portage-dev@lists.gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox