From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id B02E159CA9 for ; Tue, 29 Mar 2016 10:21:27 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id DF4CA21C071; Tue, 29 Mar 2016 10:21:22 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 52A8021C031 for ; Tue, 29 Mar 2016 10:21:22 +0000 (UTC) Received: from [128.39.168.195] (ka-195.studby.hig.no [128.39.168.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: bernalex) by smtp.gentoo.org (Postfix) with ESMTPSA id 5A171340890 for ; Tue, 29 Mar 2016 10:21:20 +0000 (UTC) Subject: Re: [gentoo-portage-dev] [PATCH v2] EbuildBuild: call _record_binpkg_info earlier (bug 578204) To: gentoo-portage-dev@lists.gentoo.org References: <1459035602-5898-1-git-send-email-zmedico@gentoo.org> <1459037608-21109-1-git-send-email-zmedico@gentoo.org> From: Alexander Berntsen Message-ID: <56FA571C.2040606@gentoo.org> Date: Tue, 29 Mar 2016 12:21:16 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.0 Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-portage-dev@lists.gentoo.org Reply-to: gentoo-portage-dev@lists.gentoo.org MIME-Version: 1.0 In-Reply-To: <1459037608-21109-1-git-send-email-zmedico@gentoo.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Archives-Salt: ee1bfba7-8c1b-4ab9-bdfd-486b7b73b2a3 X-Archives-Hash: bf9762e4b165627b4409c758beea5c7e -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512 On 27/03/16 01:13, Zac Medico wrote: > + class _RecordBinpkgInfo(AsynchronousTask): > + > + __slots__ = ('ebuild_binpkg', 'ebuild_build',) > + > + def _start(self): > + self.ebuild_build._record_binpkg_info(self.ebuild_binpkg) > + AsynchronousTask._start(self) > + Maybe docstrings are warranted? Looks OK otherwise. - -- Alexander bernalex@gentoo.org https://secure.plaimi.net/~alexander -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCgAGBQJW+lcbAAoJENQqWdRUGk8BBpIP/1DiTHK8ujnK01yOKvpp+VfU d/WCNQ7KC/QfQvbZ/jvDybvJE+o5pEOP37+hNY61lGle2kiTrSv7JBtM7Az2VohG agU/4HSFp3TnyyuaQqWrb45qWlCjkIyf8OJNr8wVzmLH6L2BXwhTIiPSt41ix+SL 2JNqtB82dh4Uq/6Bzc8C8GwPZm0XbqWc2rhS2K6JBWaJhOTDfW/HhldBHO1z6sMJ H/XgvWAZAfjhsdYGQhrYKHo+kdi8V4Je+/GFPsd/v0nPvEP6ZmW3KtAdBCbJPnIQ xOLgMp3pOWzNoP9ILn95XDydoSWNyPkUJ4VLxK+MTkwEoNJ4pJH7bz6XBWgtrzrF cXxDCTYrl2qnQq4GpwqMlJwIloYxT2px9EYoYUQPk/b+iktIazWesOcJypiS8m/S SUL6zLqjQ93+FqF4jfKni0z6j9x1WzsEFJVVetScrPUOmz4ZpUXY6w/kEjF6KrHs 7vU8ujev7nO1HZMKYGjG67l4l3oRUtwRK8dZNfnjBum0IaCZKpESCnO8d4IP7TUN Kkm4//UCZZ5K75WvycHv5cz2eb7qToeN7hGu/P2Swm4La04mnyv+0MDrY3Cm9xol M4eCBKvUiDO+xjKMoeM+sSd4eMSncPr4E3F87L6RFpgf6Z9J64OUGCaktCShvZFm f03DozRC/JUG0WfxqRpo =9je0 -----END PGP SIGNATURE-----