From: Alexander Berntsen <bernalex@gentoo.org>
To: gentoo-portage-dev@lists.gentoo.org
Subject: Re: [gentoo-portage-dev] [PATCH v2] EbuildBuild: call _record_binpkg_info earlier (bug 578204)
Date: Tue, 29 Mar 2016 12:21:16 +0200 [thread overview]
Message-ID: <56FA571C.2040606@gentoo.org> (raw)
In-Reply-To: <1459037608-21109-1-git-send-email-zmedico@gentoo.org>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
On 27/03/16 01:13, Zac Medico wrote:
> + class _RecordBinpkgInfo(AsynchronousTask):
> +
> + __slots__ = ('ebuild_binpkg', 'ebuild_build',)
> +
> + def _start(self):
> + self.ebuild_build._record_binpkg_info(self.ebuild_binpkg)
> + AsynchronousTask._start(self)
> +
Maybe docstrings are warranted? Looks OK otherwise.
- --
Alexander
bernalex@gentoo.org
https://secure.plaimi.net/~alexander
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2
iQIcBAEBCgAGBQJW+lcbAAoJENQqWdRUGk8BBpIP/1DiTHK8ujnK01yOKvpp+VfU
d/WCNQ7KC/QfQvbZ/jvDybvJE+o5pEOP37+hNY61lGle2kiTrSv7JBtM7Az2VohG
agU/4HSFp3TnyyuaQqWrb45qWlCjkIyf8OJNr8wVzmLH6L2BXwhTIiPSt41ix+SL
2JNqtB82dh4Uq/6Bzc8C8GwPZm0XbqWc2rhS2K6JBWaJhOTDfW/HhldBHO1z6sMJ
H/XgvWAZAfjhsdYGQhrYKHo+kdi8V4Je+/GFPsd/v0nPvEP6ZmW3KtAdBCbJPnIQ
xOLgMp3pOWzNoP9ILn95XDydoSWNyPkUJ4VLxK+MTkwEoNJ4pJH7bz6XBWgtrzrF
cXxDCTYrl2qnQq4GpwqMlJwIloYxT2px9EYoYUQPk/b+iktIazWesOcJypiS8m/S
SUL6zLqjQ93+FqF4jfKni0z6j9x1WzsEFJVVetScrPUOmz4ZpUXY6w/kEjF6KrHs
7vU8ujev7nO1HZMKYGjG67l4l3oRUtwRK8dZNfnjBum0IaCZKpESCnO8d4IP7TUN
Kkm4//UCZZ5K75WvycHv5cz2eb7qToeN7hGu/P2Swm4La04mnyv+0MDrY3Cm9xol
M4eCBKvUiDO+xjKMoeM+sSd4eMSncPr4E3F87L6RFpgf6Z9J64OUGCaktCShvZFm
f03DozRC/JUG0WfxqRpo
=9je0
-----END PGP SIGNATURE-----
next prev parent reply other threads:[~2016-03-29 10:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-26 23:40 [gentoo-portage-dev] [PATCH] EbuildBuild: call _record_binpkg_info earlier (bug 578204) Zac Medico
2016-03-27 0:13 ` [gentoo-portage-dev] [PATCH v2] " Zac Medico
2016-03-29 10:21 ` Alexander Berntsen [this message]
2016-03-29 16:44 ` [gentoo-portage-dev] [PATCH v3] " Zac Medico
2016-03-30 6:35 ` Alexander Berntsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56FA571C.2040606@gentoo.org \
--to=bernalex@gentoo.org \
--cc=gentoo-portage-dev@lists.gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox