From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id E0BC859CA3 for ; Tue, 15 Mar 2016 20:31:41 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 3EE1CE0863; Tue, 15 Mar 2016 20:31:38 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id A890FE085A for ; Tue, 15 Mar 2016 20:31:37 +0000 (UTC) Received: from [10.128.12.197] (unknown [100.42.98.197]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: zmedico) by smtp.gentoo.org (Postfix) with ESMTPSA id EB8CC340CD3; Tue, 15 Mar 2016 20:31:35 +0000 (UTC) Subject: Re: [gentoo-portage-dev] [Patch] Repoman rewrite stage2 modularization conversion complete To: Brian Dolbec , gentoo-portage-dev@lists.gentoo.org References: <20160110134008.4fce78c0.dolsen@gentoo.org> <5693CCAF.7020102@gentoo.org> <20160305133705.42b54258.dolsen@gentoo.org> <56E6F167.4050806@gentoo.org> <56E6F343.80005@gentoo.org> <20160314105256.37fb8e90.dolsen@gentoo.org> <56E754D3.5080308@gentoo.org> <20160314174710.4b6ebd1e.dolsen@gentoo.org> <56E75FB8.9060802@gentoo.org> <20160315120457.631e1dd3.dolsen@gentoo.org> <56E864B6.9060308@gentoo.org> <56E865BB.6040502@gentoo.org> <20160315131731.2edf502d.dolsen@gentoo.org> <56E86FB5.5080208@gentoo.org> From: Zac Medico Message-ID: <56E8711C.4070407@gentoo.org> Date: Tue, 15 Mar 2016 13:31:24 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.0 Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-portage-dev@lists.gentoo.org Reply-to: gentoo-portage-dev@lists.gentoo.org MIME-Version: 1.0 In-Reply-To: <56E86FB5.5080208@gentoo.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Archives-Salt: 6910d334-5987-4316-accd-29946e4c894a X-Archives-Hash: d052146b97917653468b1dcc0ab5fe8e On 03/15/2016 01:25 PM, Zac Medico wrote: > On 03/15/2016 01:17 PM, Brian Dolbec wrote: >> On Tue, 15 Mar 2016 12:42:51 -0700 >> Zac Medico wrote: >> >>> On 03/15/2016 12:38 PM, Zac Medico wrote: >>>> On 03/15/2016 12:04 PM, Brian Dolbec wrote: >>>>> On Mon, 14 Mar 2016 18:04:56 -0700 >>>>> Zac Medico wrote: >>>>> >>>>> >>>>>>> The only consumer for that allvalid variable is the metadata >>>>>>> UnusedCheck class. >>>>>>> >>>>>>> So the allvalid variable is True until found False >>>>>>> by whichever checks along the way find it to be False. Like a >>>>>>> fuse, it's good until it's blown, then it can never be good >>>>>>> again. I don't think this particular variable justifies a >>>>>>> special class that more fully mimics a fuse. Impossible to >>>>>>> reset it like a breaker. >>>>>> >>>>>> Yeah, let's do it. It's a great opportunity to add clarity to the >>>>>> code, and prevent future goofs. >>>>>> >>>>> >>>>> Done, it is now dynamic_data['validity_fuse'] which is a Fuse >>>>> instance. >>>> >>>> Nice, thank you! >>>> >>>> We can also use Fuse for the 'can_force' boolean, right? >>>> >>> >>> For 'changed' as well. >> >> can_force, is yes >> >> changed is a no. It is the VCS module Changes class instance. I see >> now that I described it wrong in the docstrings. Maybe I should rename >> it for better clarity to changes_inst or vcs_changes... ideas? > > Maybe 'changes'? > > Also, now that we are using Fuse, can't we stop returning things from > these functions entirely, so that dynamic_data is only updated by > side-effects? > I think 'continue' is the only one left. We could just return a single boolean, or use an exception to do what 'continue' does. -- Thanks, Zac