[gentoo-portage-dev] [PATCH] bin/portageq: add a matcher to match the orphaned (maintainer-needed) packages

[gentoo-portage-dev] [PATCH] bin/portageq: add a matcher to match the orphaned (maintainer-needed) packages

[Göktürk Yüksek]

Per GLEP 67, orphaned packages do not have a <maintainer> in metadata.xml.
They can't be matched using '--maintainer-email=maintainer-needed@gentoo.org'
anymore. Add a new command line argument '--orphaned' to match the orphaned
packages.

Signed-off-by: Göktürk Yüksek <gokturk@binghamton.edu>
---
 bin/portageq | 13 +++++++++++++
 1 file changed, 13 insertions(+)

diff --git a/bin/portageq b/bin/portageq
index 925640b..8ec81ea 100755
--- a/bin/portageq
+++ b/bin/portageq
@@ -1028,6 +1028,12 @@ class HerdMatcher(object):
 		herds = self._herds
 		return any(x in herds for x in metadata_xml.herds())
 
+class OrphanedMatcher(object):
+	def __call__(self, metadata_xml):
+		if not metadata_xml.maintainers():
+			return True
+		else:
+			return False
 
 def pquery(parser, opts, args):
 	portdb = portage.db[portage.root]['porttree'].dbapi
@@ -1090,6 +1096,8 @@ def pquery(parser, opts, args):
 		for x in opts.herd:
 			herds.extend(x.split(","))
 		xml_matchers.append(HerdMatcher(herds))
+	if opts.orphaned:
+		xml_matchers.append(OrphanedMatcher())
 
 	if opts.repo is not None:
 		repos = [portdb.repositories[opts.repo]]
@@ -1248,6 +1256,11 @@ def add_pquery_arguments(parser):
 					"longopt": "--maintainer-email",
 					"action": "append",
 					"help": "comma-separated list of maintainer email regexes to search for"
+				},
+				{
+					"longopt": "--orphaned",
+					"action": "store_true",
+					"help": "match only orphaned (maintainer-needed) packages"
 				}
 			)
 		),
-- 
2.4.10

[gentoo-portage-dev] [PATCH] bin/portageq: add a matcher to match the orphaned (maintainer-needed) packages

[Göktürk Yüksek]

Per GLEP 67, orphaned packages do not have a <maintainer> in metadata.xml.
They can't be matched using '--maintainer-email=maintainer-needed@gentoo.org'
anymore. Add a new command line argument '--orphaned' to match the orphaned
packages.

Signed-off-by: Göktürk Yüksek <gokturk@binghamton.edu>
---
 bin/portageq | 13 +++++++++++++
 1 file changed, 13 insertions(+)

diff --git a/bin/portageq b/bin/portageq
index 925640b..8ec81ea 100755
--- a/bin/portageq
+++ b/bin/portageq
@@ -1028,6 +1028,12 @@ class HerdMatcher(object):
 		herds = self._herds
 		return any(x in herds for x in metadata_xml.herds())
 
+class OrphanedMatcher(object):
+	def __call__(self, metadata_xml):
+		if not metadata_xml.maintainers():
+			return True
+		else:
+			return False
 
 def pquery(parser, opts, args):
 	portdb = portage.db[portage.root]['porttree'].dbapi
@@ -1090,6 +1096,8 @@ def pquery(parser, opts, args):
 		for x in opts.herd:
 			herds.extend(x.split(","))
 		xml_matchers.append(HerdMatcher(herds))
+	if opts.orphaned:
+		xml_matchers.append(OrphanedMatcher())
 
 	if opts.repo is not None:
 		repos = [portdb.repositories[opts.repo]]
@@ -1248,6 +1256,11 @@ def add_pquery_arguments(parser):
 					"longopt": "--maintainer-email",
 					"action": "append",
 					"help": "comma-separated list of maintainer email regexes to search for"
+				},
+				{
+					"longopt": "--orphaned",
+					"action": "store_true",
+					"help": "match only orphaned (maintainer-needed) packages"
 				}
 			)
 		),
-- 
2.4.10

Re: [gentoo-portage-dev] [PATCH] bin/portageq: add a matcher to match the orphaned (maintainer-needed) packages

[Brian Dolbec]

On Sat,  5 Mar 2016 02:36:11 -0500
Göktürk Yüksek <gokturk@binghamton.edu> wrote:

> Per GLEP 67, orphaned packages do not have a <maintainer> in
> metadata.xml. They can't be matched using
> '--maintainer-email=maintainer-needed@gentoo.org' anymore. Add a new
> command line argument '--orphaned' to match the orphaned packages.
> 
> Signed-off-by: Göktürk Yüksek <gokturk@binghamton.edu>
> ---
>  bin/portageq | 13 +++++++++++++
>  1 file changed, 13 insertions(+)
> 
> diff --git a/bin/portageq b/bin/portageq
> index 925640b..8ec81ea 100755
> --- a/bin/portageq
> +++ b/bin/portageq
> @@ -1028,6 +1028,12 @@ class HerdMatcher(object):
>  		herds = self._herds
>  		return any(x in herds for x in metadata_xml.herds())
>  
> +class OrphanedMatcher(object):
> +	def __call__(self, metadata_xml):
> +		if not metadata_xml.maintainers():
> +			return True
> +		else:
> +			return False
>  
>  def pquery(parser, opts, args):
>  	portdb = portage.db[portage.root]['porttree'].dbapi
> @@ -1090,6 +1096,8 @@ def pquery(parser, opts, args):
>  		for x in opts.herd:
>  			herds.extend(x.split(","))
>  		xml_matchers.append(HerdMatcher(herds))
> +	if opts.orphaned:
> +		xml_matchers.append(OrphanedMatcher())
>  
>  	if opts.repo is not None:
>  		repos = [portdb.repositories[opts.repo]]
> @@ -1248,6 +1256,11 @@ def add_pquery_arguments(parser):
>  					"longopt":
> "--maintainer-email", "action": "append",
>  					"help": "comma-separated
> list of maintainer email regexes to search for"
> +				},
> +				{
> +					"longopt": "--orphaned",
> +					"action": "store_true",
> +					"help": "match only orphaned
> (maintainer-needed) packages" }
>  			)
>  		),

reviewed and dealt with this on IRC.

final v2 patch merged...

-- 
Brian Dolbec <dolsen>

Re: [gentoo-portage-dev] [PATCH] bin/portageq: add a matcher to match the orphaned (maintainer-needed) packages

[Alexander Berntsen]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

I'm not sure if this is the best way to handle it, so I'm leaving it
for Zac to decide.

- -- 
Alexander
bernalex@gentoo.org
https://secure.plaimi.net/~alexander
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQIcBAEBCgAGBQJW3XHhAAoJENQqWdRUGk8BqHAP/jIguE1xAR+p6d6QyjBDVHwx
LFvwr8ecof5N2V3K4Aihzj9sg0o1XmEEqIY1d4xxNQgOOilLkKBaxSMrH8VNZDzn
P59fXnIYrgJEI7P0JDwUPxD9h2JrcFsup7OS7ZE1XEEvbkxJvhvdligr69lEKrT3
3/W8awdaQAj1dt+jLT+62RSwi2JkQKJAr94J2IfpzJEX6/byFkHEEvKhk1CNJwIn
k73969Yyxd6aguND7PAyCg+Iy8svzLQRtwJ4lFFhKxTENdb7giQ5iUCWz17cPqL2
2fkcji2f20AXeVJwXXykedek/IW2RtnUt0Gta1ljT+p6WzSY+LqNwNE8WEFWRkdA
g9oPiV605Mih6d6CR4r/fxhDXRAguP4/E6IbGuUeJdcQlc80+YdV97nVfg2+pXxF
1b6hEq+Zqv0OPnEDiftwuzh/aBeVKEg0qcRiLYbzjBN2uBhGw2ANipnHpFZM0oA9
kLl837k7fD4ZT4d9b2M3O6oRfrIfqM/q5CxJNkkI0YxXQ3e6HO3LmIGGyay2ys7s
GaTjTIxItskqCAEDefpbsaDG7qKhAsPZ2ZDzAMw/OLtPYRTLda7YBcCgg4UQlxd8
G/WSdCwmZG5gRT6ZMwEaPayJpY29RyAoqe0n5JyNrq96g4FHsuxfyGcLFVNdYpIb
0v8R2YXoqe5NSThmDVca
=V1O9
-----END PGP SIGNATURE-----

Re: [gentoo-portage-dev] [PATCH] bin/portageq: add a matcher to match the orphaned (maintainer-needed) packages

[Alexander Berntsen]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

On 06/03/16 16:12, Brian Dolbec wrote:
> reviewed and dealt with this on IRC.
> 
> final v2 patch merged...
Oh OK...

Göktürk, please try to avoid using multiple threads for patches.

Brian, thanks for dealing with it!
- -- 
Alexander
bernalex@gentoo.org
https://secure.plaimi.net/~alexander
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQIcBAEBCgAGBQJW3XMJAAoJENQqWdRUGk8BEqIQAItdlyy6lsC1ElH6aGeO6JGg
Y3o7GESdppA7zfJPWfoC7/TG4O3aBDfYtykXs7yO9J/aFtxykUlYzgasS+2CL1fy
lfJb49bUNLDrpoE4Dsb64aQEVjQvE1sqUXiMQjLF6R4psO4IOHuMCJQ60PUyC/Z3
FpADugRo/55Qq6Mlcxb8op4Eb2J0aMpHNk5c+vsRi6NNTlVYINfZMa+EA3eYSX20
H8lXENWV8zVGk5NERnF6JNjGaw8H6y+JEZ/skLL8M6YfAO/Y7DxSQNsgZvgNyquv
sze0UWQq4VsTxx4Cazw8utQHqp7CYMVpn+NlMhVUAw574G7xe72HCKaVuUbmW0Tf
id6qTD5c3zsEJ3Sh5Et3CM3v/HxFUUrq4dyZE+0L8MrKOI5Qp0+zFVLd7PKWXWu5
TNSBzd2LlRjXqXdXHIG6Giil4kMIj5SlsfGxXgJZSZhQGGNcO4qgCNkKOLzzv+xv
EFHNekG79rzCNRaONYCN0Ozv4j/MguZKGdKaCdoxcUEOoleROBXtQA1YV9rea8sg
ALKXaQ8RowthRjaxGCkQ9XVrel8OxE+78JaUX3X/qv4Xo2bJm7W24sZq5nVDAosg
VHFkRTbZvfQi2NNr+PpFWeHwgkB32cfYrzSjKaJkvp+xtGAfIZfBKdIHAmcIeHWY
7RI+CXCNyQR7Qek2AImY
=wKGT
-----END PGP SIGNATURE-----

Re: [gentoo-portage-dev] [PATCH] bin/portageq: add a matcher to match the orphaned (maintainer-needed) packages

[Zac Medico]

On 03/07/2016 04:19 AM, Alexander Berntsen wrote:
> I'm not sure if this is the best way to handle it, so I'm leaving it
> for Zac to decide.

Looks good to me. The pquery code was written with exactly this sort of
extension in mind.
-- 
Thanks,
Zac

Re: [gentoo-portage-dev] [PATCH] bin/portageq: add a matcher to match the orphaned (maintainer-needed) packages

[Alexander Berntsen]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Thanks, Zac.

I was going to push it, but it seems Brian already pushed this too.
Let's try to communicate these things on the list.
- -- 
Alexander
bernalex@gentoo.org
https://secure.plaimi.net/~alexander
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQIcBAEBCgAGBQJW3tMmAAoJENQqWdRUGk8BPmMP/1QP7M6nJelMOn7ZqgCOyS+P
R/CsSfLtetYGt6sJC5K/hYGIP9Yi+BzUem4n6l3fz+miImHn9hkXhqWF4LJAuESM
R/Flfra6YBLBg2WqdOG41Y5pYgcnAOOhx4tlHTeDem2ZLTwpvfRX7wTgfW6zVOcU
gzIpwE/lFc7HX2FY8t4RNAku18MCDv8hcTGbyMdfoBj7gh0+hDV8WUU3b7HlE85A
dE6lwtG/njoHjB0ftcEjavb6JdzoqpwIxA6+J7IGZrxER+ch73WGxweSohzNwOkI
XofCAUuJfOqW0mgVlVVceEXklYo6o2kKjVkVsYCTL6UIBdgQUwDop0WGuXv4XTl2
fiTvPUN+pnpo2usSlwpU5sxk6z74IwG6ASB/PZzyyHN2KppIJjWWh87qNRupCzij
Jwg0YLB76ECJiy9Z06v4lWBvuBy/KiLKCSmZBdz8WbuLxHBv5x5SMQV6AyjGMkYS
WU+pVgMV83xhlBY7BwzTavthLoRMOPEKkdYbeLHwt2efNi0y2dKlDsd2ROvbhq54
CRPa34BkyardsBfgmQAuCzoCVKJ6iAPImFJ+ams1g2InlB2ohh9nab60pPdoQcvt
t9l3jHuM8Y0Xr3r0Ef42MfHLL4gYcrTVygHVCzzvVG2Xgr6LA08d6Apn7Uv+COMG
325NpN9dIthe8FKswujB
=DM+e
-----END PGP SIGNATURE-----

Re: [gentoo-portage-dev] [PATCH] bin/portageq: add a matcher to match the orphaned (maintainer-needed) packages

[Brian Dolbec]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

On Tue, 8 Mar 2016 14:27:02 +0100
Alexander Berntsen <bernalex@gentoo.org> wrote:

> 
> Thanks, Zac.
> 
> I was going to push it, but it seems Brian already pushed this too.
> Let's try to communicate these things on the list.
> - -- 
> Alexander
> bernalex@gentoo.org
> https://secure.plaimi.net/~alexander

The list mail wasn't working properly and was long delayed.

So, he also was sending them to our alias which I replied to there
and subsequently merged before these showed up on the list.  Plus I also
chatted with him in our IRC channel...

And I had him change this first patch for  the patch v2 which is the one
I merged.

- -- 
Brian Dolbec <dolsen>

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.1

iQJ8BAEBCgBmBQJW3uXKXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w
ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXRBNUQ3Qzc0RTA4MUNDNzBEQjRBNEFBRjVG
QkJEMDg3Mjc1ODIwRUQ4AAoJEPu9CHJ1gg7YE+8P/Rfl7jDdjqJairTYLEa9rA/v
A4tUU5izKcHRADJcxe4yORYIBYXPcwciR9X0ldQNs+E+Mqah64LQtV9NfQ+iZTmT
eXcNnWYklvON9UvvIIaHFzZst+bVCPlW188UCnYnrgT+EHM7Zw8a2mrmiHVMIa0N
xvscbm2Yt/b2p5Lx8zftI/km2Uo/wVwW1uBHMx8cW7vKN9eYoBNHIk7M6IXYzv/5
lAUd5PivzRiBeoYD0XBcPNVrFNW6ARwMhRamaLZ4lP6xFuDzh+UFCrSfSDV89Wfn
XeYXV5NRYBXpUasXwD2Tuc4QfHyUVQV4e95nqkDyP3CHo6iSsu6VCVCVjZNCH5zx
fr33qy8gvcz3RFYGEY0UB3IKQT62kazsbapOdU81GvGMXBBoUERFVaob/FPwA/k7
TiePs8kOc1vyl1VjXji6VNyRUKff8G9VrGTANubtXj2qeampUDQ/p3OvpwCRDmGJ
jOFPb2m9gxKPnYm6YCz3U0CRNdvac/IkNE2xM7zYu82YLEAa+aLugG/sm/hNyaUu
AaOhQ/vaThfRQ5yGo/A6Cb3Lrz8VhPfhBJerM0bYI2rO9x9Ed6Nv2lfoAgNgWz4S
fpelVIZwL+htpyui43e1sQhKj7gVtuMIDjWFmSVWGou3cgYFUG7jm/jw9mRewL0S
k0D3aA5pubmBYyQ50Y1I
=/Or1
-----END PGP SIGNATURE-----

Re: [gentoo-portage-dev] [PATCH] bin/portageq: add a matcher to match the orphaned (maintainer-needed) packages

[Alexander Berntsen]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

On 08/03/16 15:46, Brian Dolbec wrote:
> The list mail wasn't working properly and was long delayed.
> 
> So, he also was sending them to our alias which I replied to there 
> and subsequently merged before these showed up on the list.  Plus I
> also chatted with him in our IRC channel...
> 
> And I had him change this first patch for  the patch v2 which is 
> the one I merged.
Thanks for the clarification, and for merging!
- -- 
Alexander
bernalex@gentoo.org
https://secure.plaimi.net/~alexander
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQIcBAEBCgAGBQJW3uZ0AAoJENQqWdRUGk8B1iMP/RFNQtNlfqVnAnFVLPRlT6WI
N4iQmWMX/HFze40qcPGOSbMDvuzOzoNjNukAFazgENxwqqGdTPoFpfFp3dPHPGbc
9cBB1XLGePYREsLUebamG3hIT7FMzmfUmCR1rufH5F16CGvLUpJTCzQLKFQpVP/z
dON8iWiMF5juTZfYA6VElMqV5bbqzFSgqs4svnxsBfneUS6wkcrvwmmnJtqpBhmo
OWvyVQ4E7E71/5ZlnkQiAton6XoxIphvgiTEFkhe8r9F9AaYLrD4EVBCOC5GPDaf
+2TwBp6U/P+ySKAbLJQhfmniaoD9Z8rb2O+VxGj5s6ZAl2L/eah17/+DKgUrlOaZ
EzJxJbf87UEnmvSKMIfMArJZpvbu5N6raJYQOjDlbc0UhsnfFanwZdwIG4pT7qvy
R0dasHgBP3CAy3kI8dB0hsIpL2vPdCusqWp21/ZoBuE7CcUEjTBMbdeWpqDVFmLt
H4excgztSW15by9VB5mmeK+5Hwyp5FOf1VJP+PgrXKWUwS4ZF/hWvIqaRCLGcXsj
tN30+xuKWK1/9uUyZXLAKNSuv3BYfoKNTCSStcG57scMOZLKFaEP7KkmNQkSjV04
IAKmlkoWIc4ARXU/pEU4n+JGawFTs8LBZn5xmBIbIAVr0eTMKP1uGoD/YMMSX06P
N2dlXThuqBunMjulZtaH
=8jw/
-----END PGP SIGNATURE-----