public inbox for gentoo-portage-dev@lists.gentoo.org
 help / color / mirror / Atom feed
* [gentoo-portage-dev] [PATCH] Clarify no binary packages error (bug 573070)
@ 2016-01-27  8:56 Alexander Berntsen
  2016-01-27 14:01 ` Brian Dolbec
  0 siblings, 1 reply; 3+ messages in thread
From: Alexander Berntsen @ 2016-01-27  8:56 UTC (permalink / raw
  To: gentoo-portage-dev

Make emerge specify that it did not find any *binary packages* when
--usepkg is active, as opposed to that it did not find any *ebuilds*, as
this was confusing behaviour.

X-Gentoo-Bug: 573070
X-Gentoo-Bug-url: https://bugs.gentoo.org/show_bug.cgi?id=573070

Signed-off-by: Alexander Berntsen <bernalex@gentoo.org>
---
 pym/_emerge/depgraph.py | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/pym/_emerge/depgraph.py b/pym/_emerge/depgraph.py
index d971749..05d1da5 100644
--- a/pym/_emerge/depgraph.py
+++ b/pym/_emerge/depgraph.py
@@ -5125,7 +5125,10 @@ class depgraph(object):
 					cp_exists = True
 					break
 
-			writemsg("\nemerge: there are no ebuilds to satisfy "+green(xinfo)+".\n", noiselevel=-1)
+			writemsg("\nemerge: there are no %s to satisfy " %
+                ("binary packages" if
+                 self._frozen_config.myopts.get("--usepkgonly", "y") == True
+                 else "ebuilds") + green(xinfo) + ".\n", noiselevel=-1)
 			if isinstance(myparent, AtomArg) and \
 				not cp_exists and \
 				self._frozen_config.myopts.get(
-- 
2.4.10



^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [gentoo-portage-dev] [PATCH] Clarify no binary packages error (bug 573070)
  2016-01-27  8:56 [gentoo-portage-dev] [PATCH] Clarify no binary packages error (bug 573070) Alexander Berntsen
@ 2016-01-27 14:01 ` Brian Dolbec
  2016-01-28 11:59   ` Alexander Berntsen
  0 siblings, 1 reply; 3+ messages in thread
From: Brian Dolbec @ 2016-01-27 14:01 UTC (permalink / raw
  To: gentoo-portage-dev

On Wed, 27 Jan 2016 09:56:17 +0100
Alexander Berntsen <bernalex@gentoo.org> wrote:

> Make emerge specify that it did not find any *binary packages* when
> --usepkg is active, as opposed to that it did not find any *ebuilds*,
> as this was confusing behaviour.
> 
> X-Gentoo-Bug: 573070
> X-Gentoo-Bug-url: https://bugs.gentoo.org/show_bug.cgi?id=573070
> 
> Signed-off-by: Alexander Berntsen <bernalex@gentoo.org>
> ---
>  pym/_emerge/depgraph.py | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/pym/_emerge/depgraph.py b/pym/_emerge/depgraph.py
> index d971749..05d1da5 100644
> --- a/pym/_emerge/depgraph.py
> +++ b/pym/_emerge/depgraph.py
> @@ -5125,7 +5125,10 @@ class depgraph(object):
>  					cp_exists = True
>  					break
>  
> -			writemsg("\nemerge: there are no ebuilds to
> satisfy "+green(xinfo)+".\n", noiselevel=-1)
> +			writemsg("\nemerge: there are no %s to
> satisfy " %
> +                ("binary packages" if
> +                 self._frozen_config.myopts.get("--usepkgonly", "y")
> == True
> +                 else "ebuilds") + green(xinfo) + ".\n",
> noiselevel=-1) if isinstance(myparent, AtomArg) and \
>  				not cp_exists and \
>  				self._frozen_config.myopts.get(

works for me

-- 
Brian Dolbec <dolsen>



^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [gentoo-portage-dev] [PATCH] Clarify no binary packages error (bug 573070)
  2016-01-27 14:01 ` Brian Dolbec
@ 2016-01-28 11:59   ` Alexander Berntsen
  0 siblings, 0 replies; 3+ messages in thread
From: Alexander Berntsen @ 2016-01-28 11:59 UTC (permalink / raw
  To: gentoo-portage-dev

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Pushed as 9c9165fb9420a285e8e2c62cb9ba8eb91120cb66.

- -- 
Alexander
bernalex@gentoo.org
https://secure.plaimi.net/~alexander
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQIcBAEBCgAGBQJWqgK+AAoJENQqWdRUGk8BDjcQAMIoIo80WQrqTlTN7/caw3Bn
tHrMI+z+0Nj5LMhmi8k+hPv8seMohWtIMgCuHVolK5/4gMRSvK6uh0AK97NyLzF/
dHg9hr8xZ7NpAMpSoxkZm8S3m7ODsxfuVkEIKhzzz81/rAr9fKKHYLa4vm/FSMZ4
o3aL1tqmifXXi1m0Mu3wythiEADy5NiufQAvmNGdV6tO9RhorUs+dIBKWZwsV68s
YVLFilmuu+qnxXKpnbEszsO6Iez9YNMpfI+zgNjGHtDhaHZIr6mzAiVOqLOvx6uN
rjaSQphR2pZ0jgYZ1CMOp5ZcGA4MDSnMY7pk5efD6eRYsRsJmGhBWRKOiGkdYQx3
r80jbndfDSfuzhc4gT2alK4Et/kYbigWjEPnka5PDt3eBvovwHkaWdUJIrLf+m0I
jUGCZbMg7eaZFWtEV9qLaUFSqYLy13MJTCx5Oxpwu8AQve2xNNoPDMWdrQsAMxmm
ZWx8n34Y2o+GUH+alVxB4XunJig706JXxJlHe8OHRbHJizV3snNlyPtEqBOt3sqC
I4dSmV+bmdZW2AVo55hP73L7WDDnun2szoBv6vGisEicPginBYmW6bSpb2oAfOH7
C4/5Bia7FSE3MnkOeshIR3zFvS3z+CahMPtLvTvq6HZIqWahUZN1XZPVSz4N+fiZ
j3jO6j3hscSF5kllVQlC
=3hUK
-----END PGP SIGNATURE-----


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2016-01-28 12:00 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-01-27  8:56 [gentoo-portage-dev] [PATCH] Clarify no binary packages error (bug 573070) Alexander Berntsen
2016-01-27 14:01 ` Brian Dolbec
2016-01-28 11:59   ` Alexander Berntsen

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox