[gentoo-portage-dev] [PATCH] emerge-webrsync: suppress tar future timestamp warning (bug 572578)

[gentoo-portage-dev] [PATCH] emerge-webrsync: suppress tar future timestamp warning (bug 572578)

[Zac Medico]

As reported in bug 572578, the gentoo rsync repository contains a file
which intentionally has a future timestamp. Since tar future timestamp
warnings are irrelevant, suppress them if tar supports the option.

X-Gentoo-Bug: 572578
X-Gentoo-Bug-url: https://bugs.gentoo.org/show_bug.cgi?id=572578
---
 bin/emerge-webrsync | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/bin/emerge-webrsync b/bin/emerge-webrsync
index 9961ad8..ee0d980 100755
--- a/bin/emerge-webrsync
+++ b/bin/emerge-webrsync
@@ -66,6 +66,9 @@ fi
 do_verbose=0
 do_debug=0
 keep=false
+tar_opts=()
+
+[[ $(tar --help) == *--warning* ]] && tar_opts+=(--warning=no-timestamp)
 
 if has webrsync-gpg ${FEATURES} ; then
 	WEBSYNC_VERIFY_SIGNATURE=1
@@ -86,7 +89,7 @@ do_tar() {
 		*.gz)   decompressor="zcat"  ;;
 		*)      decompressor="cat"   ;;
 	esac
-	${decompressor} "${file}" | tar "$@"
+	${decompressor} "${file}" | tar "${tar_opts[@]}" "$@"
 	_pipestatus=${PIPESTATUS[*]}
 	[[ ${_pipestatus// /} -eq 0 ]]
 }
@@ -225,7 +228,7 @@ sync_local() {
 			return 1
 		fi
 	else
-		if ! do_tar "${file}" xf -; then
+		if ! do_tar "${file}" -xf -; then
 			eecho "tar failed to extract the image. tarball is corrupt? (${file})"
 			rm -fr portage
 			return 1
-- 
2.4.10

Re: [gentoo-portage-dev] [PATCH] emerge-webrsync: suppress tar future timestamp warning (bug 572578)

[Alexander Berntsen]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

While I'm not entirely convinced this should be dealt with like this,
or indeed that it should be dealt with *in Portage* at all, the patch
is mostly harmless, so ACK if you think it's worthwhile.

- -- 
Alexander
bernalex@gentoo.org
https://secure.plaimi.net/~alexander
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQIcBAEBCgAGBQJWqHgzAAoJENQqWdRUGk8BpjwQAKUXncBzNF4t4fZF3lmoA4/1
YWsdJqU9sEBKFbQfHefk8M5N27TV8j4a3IRgmMgWywtmjD7K9RrDMca6OPSDiLPD
s8dPRF9tqjlEfnPOLUlkLSGKV3wu4JUsRbvizFtn88+1blFHeHpKuMZEfh6zNt8a
ioe+6DCQXha4HlNszsxJysx9kxV4rFLBYegvqcft+3aqmj/dGV3uYzw3VSPi+lKP
9X8pK0/TH1t43eJXxQe4EseejfbvTiPakq8N8qSxeYA9nGbd1gWmhBu+gmRhshIe
v23XHKnQJO7h6XiO0hP+VRr/WYlYD4i1Bdb8xouKmvO1N3lAjkTlg4L7jhqCdsH0
FVj+k8BZHpEn0TxgnBCvm03l8hQ8WeCGklvvlJTA/HxzOxhtls+RWpv/y7DSnoT4
0cvZIHc4tXuESjqPURUGrE3+jHAmvPfLRuGNeF60Db4AWzlk5Kxpr409j0I1QK2c
EWLPbRciu2kzgzu2QnUm6IQMLuN38JQIHxm+XB0hHQr+WTfT8heYQQqh0IRANGkJ
Cr6ixV1JZZw5l2VxMT59cz7TSYznG1ZSsIoGQ+t69bHMKvoD4OJ+Dkrw52LLCsPV
Klyq/LU1Knuo1+DPxVYFfvP6B1awebXj20PQEGfl2Y5BKRvcDhrsaaa3igWNEHIg
zW3LmUKkPo3pJI/40ibs
=+EXv
-----END PGP SIGNATURE-----