[gentoo-portage-dev] [PATCH] Print WORKDIR & D sizes in build logs

[gentoo-portage-dev] [PATCH] Print WORKDIR & D sizes in build logs

[Michał Górny]

---
 bin/phase-functions.sh | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/bin/phase-functions.sh b/bin/phase-functions.sh
index 0b853bf..6a47fed 100644
--- a/bin/phase-functions.sh
+++ b/bin/phase-functions.sh
@@ -593,6 +593,15 @@ __dyn_install() {
 	__vecho
 	__ebuild_phase post_src_install
 
+	# record build & installed size in build log
+	if type -P du &>/dev/null; then
+		local sz=( $(du -ks "${WORKDIR}") )
+		einfo "Final size of build directory: ${sz[0]} KiB"
+		sz=( $(du -ks "${D}") )
+		einfo "Final size of installed tree: ${sz[0]} KiB"
+		__vecho
+	fi
+
 	cd "${PORTAGE_BUILDDIR}"/build-info
 	set -f
 	local f x
-- 
2.6.4

Re: [gentoo-portage-dev] [PATCH] Print WORKDIR & D sizes in build logs

[Ulrich Mueller]

[-- Attachment #1: Type: text/plain, Size: 840 bytes --]

>>>>> On Sun, 27 Dec 2015, Michał Górny wrote:

> ---
>  bin/phase-functions.sh | 9 +++++++++
>  1 file changed, 9 insertions(+)

> diff --git a/bin/phase-functions.sh b/bin/phase-functions.sh
> index 0b853bf..6a47fed 100644
> --- a/bin/phase-functions.sh
> +++ b/bin/phase-functions.sh
> @@ -593,6 +593,15 @@ __dyn_install() {
>  	__vecho
>  	__ebuild_phase post_src_install
 
> +	# record build & installed size in build log
> +	if type -P du &>/dev/null; then
> +		local sz=( $(du -ks "${WORKDIR}") )
> +		einfo "Final size of build directory: ${sz[0]} KiB"
> +		sz=( $(du -ks "${D}") )
> +		einfo "Final size of installed tree: ${sz[0]} KiB"
> +		__vecho
> +	fi
> +
>  	cd "${PORTAGE_BUILDDIR}"/build-info
>  	set -f
>  	local f x
> -- 
> 2.6.4

Will this be called before or after prepcompress?

Ulrich

[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]

Re: [gentoo-portage-dev] [PATCH] Print WORKDIR & D sizes in build logs

[Michał Górny]

[-- Attachment #1: Type: text/plain, Size: 1164 bytes --]

On Mon, 28 Dec 2015 09:17:55 +0100
Ulrich Mueller <ulm@gentoo.org> wrote:

> >>>>> On Sun, 27 Dec 2015, Michał Górny wrote:  
> 
> > ---
> >  bin/phase-functions.sh | 9 +++++++++
> >  1 file changed, 9 insertions(+)  
> 
> > diff --git a/bin/phase-functions.sh b/bin/phase-functions.sh
> > index 0b853bf..6a47fed 100644
> > --- a/bin/phase-functions.sh
> > +++ b/bin/phase-functions.sh
> > @@ -593,6 +593,15 @@ __dyn_install() {
> >  	__vecho
> >  	__ebuild_phase post_src_install  
>  
> > +	# record build & installed size in build log
> > +	if type -P du &>/dev/null; then
> > +		local sz=( $(du -ks "${WORKDIR}") )
> > +		einfo "Final size of build directory: ${sz[0]} KiB"
> > +		sz=( $(du -ks "${D}") )
> > +		einfo "Final size of installed tree: ${sz[0]} KiB"
> > +		__vecho
> > +	fi
> > +
> >  	cd "${PORTAGE_BUILDDIR}"/build-info
> >  	set -f
> >  	local f x
> > -- 
> > 2.6.4  
> 
> Will this be called before or after prepcompress?

I'm sorry, I have missed this mail earlier.

It is called before prepcompress and before stripping, I think.

-- 
Best regards,
Michał Górny
<http://dev.gentoo.org/~mgorny/>

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 949 bytes --]

Re: [gentoo-portage-dev] [PATCH] Print WORKDIR & D sizes in build logs

[Alexander Berntsen]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

LGTM.

- -- 
Alexander
bernalex@gentoo.org
https://secure.plaimi.net/~alexander
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQIcBAEBCgAGBQJWlP8MAAoJENQqWdRUGk8B2lMP/0PEe5zwEQzesacPogONqsB5
v/Tuh9HoGgPbGZmI/nIbMC5yjEL2x63f22sszly4LWU6HqqOncH3qW1VCYMZoDju
nsVMO6Jz/Gjefo/HbaIQYb/duEL7nHB90jG78Z0bLPun/3tSDe+exfOHboNZKxaE
138BYe6sDEtoueSRlHV++MF4v8Ukb06WiM89EAS/SlklvstzhnnQsagjMcqrm4WL
hsGEkPvPFIxxqaLSxAArLXDAh9SoUtwieGDxu7xyD9P1SDXdi+eKXZ9fXU3uJ39c
c2vY0qNghboLxayLDUZVUdZnloRtEvkI48EZ55m2DRQQIGBFp/c8NGuWDBaFnXH5
rO71Buoie4s4FKZ9ktzTcd2+4Vgz1hYhK06ZG2aYyNMFOZJzSjwbAZ47xaJe1UWG
kxFxe/m39qhdwIC97mVD8REWtc0sbVM0nPcLbr1zF/3RlKMaFlQNmjmn6ESxqKB7
jjqBQO6u9m46mf7zEQ7SZQmgNRYgw0mWUSxWLySgXSQN00Qk03dvvV9pd8FMuFrB
LxWvjIxrQcGyvwX9i7/a2rJmfZ7LO10LyGGdA3uhq0qGsZeNNkd+q4IdIrK3uXxt
YERcLHnmwyjMHGdH2hGd+Edh67ZEVu350lwcl5UPHZeretCfUPOSqeRUNn1GiywT
VrQWq3NN/g9jDJTBLLpg
=84f9
-----END PGP SIGNATURE-----

Re: [gentoo-portage-dev] [PATCH] Print WORKDIR & D sizes in build logs

[Michał Górny]

[-- Attachment #1: Type: text/plain, Size: 248 bytes --]

On Sun, 27 Dec 2015 23:58:42 +0100
Michał Górny <mgorny@gentoo.org> wrote:

> ---
>  bin/phase-functions.sh | 9 +++++++++
>  1 file changed, 9 insertions(+)

Pushed.

-- 
Best regards,
Michał Górny
<http://dev.gentoo.org/~mgorny/>

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 949 bytes --]

Re: [gentoo-portage-dev] [PATCH] Print WORKDIR & D sizes in build logs

[Alexander Berntsen]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

testDoebuild
(portage.tests.ebuild.test_doebuild_fd_pipes.DoebuildFdPipesTestCase)...
FAIL

Travelling and stuff, but I'll try to look at it later; if you haven't
got to it by then.
- -- 
Alexander
bernalex@gentoo.org
https://secure.plaimi.net/~alexander
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQIcBAEBCgAGBQJWmPzPAAoJENQqWdRUGk8BXD4P/3bZWya4JKybeS+8hxNxhOKb
je4yqS8DhSHnjhOvfGn2x/7tuf5PJ6Ik08KM/1GAnMhb1/TGC+sap+/j6R+nq0na
4n/51iOfvhKvtgAuwULZhJK8prlXT7FtrW06C55mFHXdhRrFzE8dopFK81XZLdsd
GCt/AgquJ5gpYJGZrYv5vchTVzryqLcIXty1ZXDQiNAsN+WR9l3/s7dkeCS33Rll
b9lw5a6QartpoGRBsPcto/bTcqnDgufP2f2wUzctaddt7Byy4C/LX4Mq5kUvSuqs
7uto54Hy2MkvHMjXW6IgCCQEId7QWTFstjWIAkMW7V4i+Yt5PoEEuqDJx5uhaEmj
fwYEHjSqVrh9+AzJsZ4J6HS3XCs7W2bmwGV9TjKOtzs70lhGKqjwlM4B2tUpZhmU
SVMRPkayNfjp23wOL9So3kcdkzFM8flzv/5by29KCbf8vWnECIEE612/1my6nMeX
evMKDOIu8y/xn8BhzZisN7wFWSyDIgca5+hv/o0wHQK0BnpwTv3d9Aad7Xc/ZIHB
Kn0YC0BSlS4uvhDDYD+yv0EjMynlBNEVIOFkBAPtVSb7vK98DZsIg8wEj8liX54R
/G7QHPO6t+rh3BKQt4OkZq9LLS71utrSk3tKxrmB9ZGR/2B3evIx3Rl8MAuTl8Db
LDsu474emzbY6zhQVSY/
=HihE
-----END PGP SIGNATURE-----

Re: [gentoo-portage-dev] [PATCH] Print WORKDIR & D sizes in build logs

[Michał Górny]

[-- Attachment #1: Type: text/plain, Size: 672 bytes --]

On Fri, 15 Jan 2016 15:06:08 +0100
Alexander Berntsen <bernalex@gentoo.org> wrote:

> testDoebuild
> (portage.tests.ebuild.test_doebuild_fd_pipes.DoebuildFdPipesTestCase)...
> FAIL
> 
> Travelling and stuff, but I'll try to look at it later; if you haven't
> got to it by then.

You make it look like you noticed it before I pinged you about it! :-P

Looks like the test relies on the phase outputting only whatever's
inside. Not sure how to proceed best. Should I push all that output
into stderr maybe, as a workaround? Or disable printing sizes
conditionally to verboseness level?

-- 
Best regards,
Michał Górny
<http://dev.gentoo.org/~mgorny/>

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 949 bytes --]

Re: [gentoo-portage-dev] [PATCH] Print WORKDIR & D sizes in build logs

[Alexander Berntsen]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

On 15/01/16 15:21, Michał Górny wrote:
> You make it look like you noticed it before I pinged you about it! 
> :-P
It was just a note for myself to fix it later or at least see to that
someone else fixes it.

> Looks like the test relies on the phase outputting only whatever's
>  inside. Not sure how to proceed best. Should I push all that
> output into stderr maybe, as a workaround? Or disable printing
> sizes conditionally to verboseness level?
I think 2 sounds OK. But the test is meant to catch a regression on
fd_pipes; perhaps the test should be changed rather than the code.
What do you think, Zac?
- -- 
Alexander
bernalex@gentoo.org
https://secure.plaimi.net/~alexander
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQIcBAEBCgAGBQJWmQEhAAoJENQqWdRUGk8BnvkQAMqI9kDWeOSWZi/kuHAJJlvB
YYOLSG/3VRrtnIqEOvvvEl/v50hFgnV/aO85h4UHJ8ZfFuxKDkPS/CVmLUNNA9xp
dGYNXahXfcE5u3bhksoggTMdnmL0cthbm95/R48SHHwpcnfAgRv7YVuriuS7nujg
gFqe3AUyTYkFwgcv1aym7pNm1Eq0poQQcMSAnmLb4f+6H113ZJUhnxCeU+lwomdP
YVheLx2swBEmQq1GrwBP74qD/7G5C9geNJ1v7K64Nsldxk64pifPDXjHSLK+6xTR
+afX4AEfN8PdHhjbSQJdlll2DZjEM4zHKQ7ZmtWBtYeJs/Hup/lO5uXyXSPVht3D
AcOm+DpApy1nk+genYwP8XjpRftqREqrfNilFZU8seRyK1vqmwuOG8fWAqfKwGFG
x7+Hf6c2rr8yjjyNYY5gZ4hhGoQsb+nwRgn4hKP6RGdEqtTclGI1/H1VuH9Ai7LK
JPbBTcNMRzNGlif+xqOBlMzGAfNXTu2NqoZxDoXQ/bzg/QnHhCMUD0ciI04mUSdi
jJRNLuIUanD8GIxLER5BkrNXzvWJ64a1DMrcSu12MJAGp1frTu5vJuPUQ2Kw5nQS
76OkHtBnXTNO0z+7kdcEnaZ31qV8ZMU7xV6z+06SlbpDuShrl5kQ8psBRXG3CwXN
AP1MdmNxi4XKBPtZDjFx
=KngQ
-----END PGP SIGNATURE-----