From: Zac Medico <zmedico@gentoo.org>
To: gentoo-portage-dev@lists.gentoo.org,
Lucian Poston <lucian.poston@gmail.com>
Subject: Re: [gentoo-portage-dev] [PATCH] emerge: Add --autounmask-only parameter
Date: Wed, 23 Dec 2015 17:58:05 -0800 [thread overview]
Message-ID: <567B512D.5010303@gentoo.org> (raw)
In-Reply-To: <1450906772-14853-1-git-send-email-lucian.poston@gmail.com>
On 12/23/2015 01:39 PM, Lucian Poston wrote:
> diff --git a/pym/_emerge/actions.py b/pym/_emerge/actions.py
> index a080ba4..5004fd1 100644
> --- a/pym/_emerge/actions.py
> +++ b/pym/_emerge/actions.py
> @@ -327,6 +327,10 @@ def action_build(settings, trees, mtimedb,
> display_missing_pkg_set(root_config, e.value)
> return 1
>
> + if "--autounmask-only" in myopts:
> + mydepgraph.display_autounmask()
> + return 0
> +
> if not success:
> mydepgraph.display_problems()
> return 1
I think we should also call display_problems just before
display_autounmask, since it could display some very useful information.
Otherwise, the patch looks good to me.
--
Thanks,
Zac
next prev parent reply other threads:[~2015-12-24 1:58 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-23 21:39 [gentoo-portage-dev] [PATCH] emerge: Add --autounmask-only parameter Lucian Poston
2015-12-24 1:58 ` Zac Medico [this message]
2015-12-24 3:18 ` Lucian Poston
2015-12-24 14:38 ` [gentoo-portage-dev] [PATCH v2] " Lucian Poston
2015-12-25 20:46 ` Zac Medico
2015-12-25 22:31 ` Brian Dolbec
2015-12-29 10:45 ` Alexander Berntsen
2015-12-29 10:48 ` Alexander Berntsen
2016-01-02 23:05 ` [gentoo-portage-dev] [PATCH v3] emerge: Add --autounmask-only parameter (bug 570672) Lucian Poston
2016-01-04 10:38 ` [gentoo-portage-dev] " Alexander Berntsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=567B512D.5010303@gentoo.org \
--to=zmedico@gentoo.org \
--cc=gentoo-portage-dev@lists.gentoo.org \
--cc=lucian.poston@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox